Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2332983002: Make ipdf_formnotify a pure virtual interface (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make ipdf_formnotify a pure virtual interface Removes some unused code for the default implementation, Committed: https://pdfium.googlesource.com/pdfium/+/f786c267e290c259b38afe900b8abd23812a575b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -48 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfdoc/include/ipdf_formnotify.h View 1 chunk +10 lines, -10 lines 0 comments Download
D core/fpdfdoc/ipdf_formnotify.cpp View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-09-12 21:42:14 UTC) #3
dsinclair
lgtm
4 years, 3 months ago (2016-09-13 13:21:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332983002/1
4 years, 3 months ago (2016-09-13 13:21:38 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 13:21:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f786c267e290c259b38afe900b8abd23812a...

Powered by Google App Engine
This is Rietveld 408576698