Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2332973002: Fix crash of paint invalidation tracking after a new frame is created (Closed)

Created:
4 years, 3 months ago by Xianzhu
Modified:
4 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash of paint invalidation tracking after a new frame is created BUG=645950 Committed: https://crrev.com/50d3fe174312ef3858b4c53d3496684106a86ebe Cr-Commit-Position: refs/heads/master@{#418164}

Patch Set 1 #

Patch Set 2 : platform-neutual #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/insert-frame.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/insert-frame-expected.txt View 1 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Xianzhu
This CL may look familiar to you if you reviewed Patch Set 5 (has been ...
4 years, 3 months ago (2016-09-12 21:41:04 UTC) #2
chrishtr
lgtm
4 years, 3 months ago (2016-09-12 21:42:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332973002/1
4 years, 3 months ago (2016-09-12 21:56:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332973002/20001
4 years, 3 months ago (2016-09-12 22:01:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/291703)
4 years, 3 months ago (2016-09-13 02:31:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332973002/20001
4 years, 3 months ago (2016-09-13 02:33:02 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-13 03:56:29 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 03:58:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50d3fe174312ef3858b4c53d3496684106a86ebe
Cr-Commit-Position: refs/heads/master@{#418164}

Powered by Google App Engine
This is Rietveld 408576698