Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2332963003: Unset CompositorWorkerGlobalScope during WorkerGlobalScope::dipose. (Closed)

Created:
4 years, 3 months ago by flackr
Modified:
4 years, 3 months ago
Reviewers:
Ian Vollick, bokan
CC:
blink-reviews, chromium-reviews, haraken, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unset CompositorWorkerGlobalScope during WorkerGlobalScope::dipose. We will still generate compositor frames while shutting down the compositor worker global scope, so we need to ensure we don't try to run our animation callbacks on the now disposed worker thread. BUG=645991 TEST=CompositorWorkerThreadTest.Shutdown

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -6 lines) Patch
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 6 chunks +46 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/CompositorProxyClientImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
flackr
Hey Ian, can you take a look at this simple patch. This ensures that after ...
4 years, 3 months ago (2016-09-12 22:35:22 UTC) #2
Ian Vollick
On 2016/09/12 22:35:22, flackr wrote: > Hey Ian, can you take a look at this ...
4 years, 3 months ago (2016-09-12 23:41:02 UTC) #3
flackr
+bokan, can you give the OWNERS stamp for Source/web?
4 years, 3 months ago (2016-09-13 14:54:58 UTC) #5
bokan
lgtm
4 years, 3 months ago (2016-09-13 15:00:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332963003/1
4 years, 3 months ago (2016-09-13 15:06:35 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 15:09:17 UTC) #10
Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698