Remove hand-written assembly ArrayPush stubs

src/array.js

Index: src/array.js
diff --git a/src/array.js b/src/array.js
index b3b25ed260c505f35c058c0cdabd8e8b9b8c057c..b7228459b079bdba7220c1de383be4fb32eb06af 100644
--- a/src/array.js
+++ b/src/array.js
@@ -470,7 +470,9 @@ function ArrayPush() {
     return ObservedArrayPush.apply(this, arguments);
 
   for (var i = 0; i < m; i++) {
-    this[i+n] = %_Arguments(i);
+    // Use SetProperty rather than a direct keyed store to ensure that the store
+    // site doesn't become poisened with an elements transition KeyedStoreIC.
+    %SetProperty(this, i+n, %_Arguments(i), 0, 0);

[Michael Starzinger, 2014/04/11 13:12:08]

This will break for primitive values as "this" because there is not ToObject
conversion anywhere and primitive values seem to be ignored by
Runtime_SetProperty.

Also this passes "sloppy" as the language mode, which causes this [[Put]] not to
throw if the element cannot be put according to [[CanPut]].

Both of the above cases are already broken right now. So I am fine with leaving
this as it is, but can we leave a TODO that this is a temporary workaround? You
can assign this TODO to me if you want.

[danno, 2014/04/16 14:34:38]

Done.

   }
 
   var new_length = n + m;