Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 233293004: Remove unimplemented and unused IsSchemeBitSet method (Closed)

Created:
6 years, 8 months ago by robwu
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove unimplemented and unused IsSchemeBitSet method The IsSchemeBitSet method was added in https://chromiumcodereview.appspot.com/12792005/#ps4001, but removed during a refactor within the same CL. It was never used, so it can be removed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M extensions/common/url_pattern.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robwu
6 years, 8 months ago (2014-04-10 18:11:38 UTC) #1
not at google - send to devlin
lgtm but you can remove the BUG= line.
6 years, 8 months ago (2014-04-10 19:24:55 UTC) #2
robwu
The CQ bit was checked by rob@robwu.nl
6 years, 8 months ago (2014-04-10 19:28:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob@robwu.nl/233293004/1
6 years, 8 months ago (2014-04-10 19:28:59 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 21:43:42 UTC) #5
Message was sent while issue was closed.
Change committed as 263091

Powered by Google App Engine
This is Rietveld 408576698