Fix post submit problems for the vector of smart pointers change.

Fix post submit problems for the vector of smart pointers change.

BruceDawson noticed that we had an unused variable, and a place
where we were not using the for_each statement that we could be
using it, this fixes those problems.

BUG=610521, 427616
Committed: https://crrev.com/2431b127ba05526cb9dcdaea612b8aacc206d954
Cr-Commit-Position: refs/heads/master@{#418111}

[Pete Williamson, 2016-09-12 20:25:43]

petewil@chromium.org changed reviewers:
+ brucedawson@chromium.org, dewittj@chromium.org

[brucedawson, 2016-09-12 20:46:52]

Description was changed from

==========
Fix post submit problems for the vector of smart pointers change.

BruceDawson noticed that we had an unused variable, and a place
where we were not using the for_each statement that we could be
using it, this fixes those problems.

BUG=610521
==========

to

==========
Fix post submit problems for the vector of smart pointers change.

BruceDawson noticed that we had an unused variable, and a place
where we were not using the for_each statement that we could be
using it, this fixes those problems.

BUG=610521,427616
==========

[brucedawson, 2016-09-12 20:47:11]

I added the /analyze tracking bug, since that's what actually found it.

lgtm

[dewittj, 2016-09-12 20:59:48]

rubber stamp lgtm

[Pete Williamson, 2016-09-12 21:37:10]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2016-09-12 21:38:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 22:28:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 22:28:42]

Failed to apply patch for components/offline_pages/background/request_picker.cc:
While running git apply --index -3 -p1;
  error: patch failed: components/offline_pages/background/request_picker.cc:256
  Falling back to three-way merge...
  Applied patch to 'components/offline_pages/background/request_picker.cc' with
conflicts.
  U components/offline_pages/background/request_picker.cc

Patch:       components/offline_pages/background/request_picker.cc
Index: components/offline_pages/background/request_picker.cc
diff --git a/components/offline_pages/background/request_picker.cc
b/components/offline_pages/background/request_picker.cc
index
c51f030d6f72829407dd0dfa96b0f1c1c08b3d3d..06fa6823c54f64c77912006f52bc07fcf036704c
100644
--- a/components/offline_pages/background/request_picker.cc
+++ b/components/offline_pages/background/request_picker.cc
@@ -240,7 +240,6 @@ void RequestPicker::SplitRequests(
     std::vector<std::unique_ptr<SavePageRequest>> requests,
     std::vector<std::unique_ptr<SavePageRequest>>* valid_requests,
     std::vector<std::unique_ptr<SavePageRequest>>* expired_requests) {
-  std::vector<std::unique_ptr<SavePageRequest>>::iterator request;
   for (auto& request : requests) {
     if (base::Time::Now() - request->creation_time() >=
         base::TimeDelta::FromSeconds(kRequestExpirationTimeInSeconds)) {
@@ -256,11 +255,9 @@ void RequestPicker::SplitRequests(
 void RequestPicker::OnRequestExpired(
     const RequestQueue::UpdateMultipleRequestResults& results,
     const std::vector<std::unique_ptr<SavePageRequest>> requests) {
-  std::vector<std::unique_ptr<SavePageRequest>>::const_iterator request;
-  for (request = requests.begin(); request != requests.end(); ++request)
+  for (const auto& request : requests)
     notifier_->NotifyCompleted(
-        *(request->get()),
-        RequestCoordinator::BackgroundSavePageResult::EXPIRED);
+        *request, RequestCoordinator::BackgroundSavePageResult::EXPIRED);
 }
 
 }  // namespace offline_pages

[Pete Williamson, 2016-09-12 23:08:30]

The CQ bit was checked by petewil@chromium.org

[Pete Williamson, 2016-09-12 23:08:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dewittj@chromium.org, brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/2332923003/#ps20001
(title: "Merge with request picker changes.")

[commit-bot: I haz the power, 2016-09-12 23:09:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 00:03:38]

Description was changed from

==========
Fix post submit problems for the vector of smart pointers change.

BruceDawson noticed that we had an unused variable, and a place
where we were not using the for_each statement that we could be
using it, this fixes those problems.

BUG=610521,427616
==========

to

==========
Fix post submit problems for the vector of smart pointers change.

BruceDawson noticed that we had an unused variable, and a place
where we were not using the for_each statement that we could be
using it, this fixes those problems.

BUG=610521,427616

Committed: https://crrev.com/2431b127ba05526cb9dcdaea612b8aacc206d954
Cr-Commit-Position: refs/heads/master@{#418111}
==========

[commit-bot: I haz the power, 2016-09-13 00:03:39]

Patchset 2 (id:??) landed as
https://crrev.com/2431b127ba05526cb9dcdaea612b8aacc206d954
Cr-Commit-Position: refs/heads/master@{#418111}