Remove GYP files.

Remove GYP files.

This removes all .gyp files not called "compiled_resources" in the main Chromium repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/315e4cfd4b1a120c3e2b28812afc5dbdc292bebe
Cr-Commit-Position: refs/heads/master@{#418654}

[brettw, 2016-09-12 21:00:56]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-09-12 21:00:57]

Description was changed from

==========
Remove GYP files.

This removes all .gyp files not called "compiled_resources" in the main Chromium
repository.
==========

to

==========
Remove GYP files.

This removes all .gyp files not called "compiled_resources" in the main Chromium
repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[commit-bot: I haz the power, 2016-09-12 21:01:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 21:08:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 21:08:48]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-09-12 21:13:15]

Put back a few

[brettw, 2016-09-12 21:13:17]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 21:13:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 21:21:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 21:21:16]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-09-12 21:26:39]

chromeos

[brettw, 2016-09-12 21:26:41]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 21:27:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 23:53:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 23:53:38]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-09-13 03:32:13]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[fukino, 2016-09-13 05:18:41]

fukino@chromium.org changed reviewers:
+ fukino@chromium.org

[fukino, 2016-09-13 05:18:42]

Could you keep ui/file_manager/*.gypi and third_party/closure_compiler/*.gypi,
as they are used in compiled_resources.gyp?

[brettw, 2016-09-13 17:16:56]

Done, thanks for noticing.

[brettw, 2016-09-13 17:18:19]

Put back ui and closure compiler

[brettw, 2016-09-13 17:18:20]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 17:18:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 18:44:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:44:46]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-09-13 21:05:39]

Description was changed from

==========
Remove GYP files.

This removes all .gyp files not called "compiled_resources" in the main Chromium
repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Remove GYP files.

This removes all .gyp files not called "compiled_resources" in the main Chromium
repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.linux:closure_compilation
==========

[Dirk Pranke, 2016-09-13 21:06:31]

I added closure_compilation to the list of extra trybots, just to be safe.

lgtm otherwise.

[brettw, 2016-09-13 21:33:26]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-09-13 21:33:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 21:48:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 21:48:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Will Harris, 2016-09-13 22:03:46]

can you put a BUG= ?

[brettw, 2016-09-13 22:39:10]

brettw@chromium.org changed reviewers:
+ scottmg@chromium.org

[brettw, 2016-09-13 22:39:12]

+scottmg for crashpad

[scottmg, 2016-09-13 22:40:35]

On 2016/09/13 22:39:12, brettw (ping on IM after 24h) wrote:
> +scottmg for crashpad

I don't think there's any point to deleting the ones in third_party/crashpad as
they're just going to get rolled in again next time.

[brettw, 2016-09-13 22:45:27]

On 2016/09/13 22:40:35, scottmg wrote:
> On 2016/09/13 22:39:12, brettw (ping on IM after 24h) wrote:
> > +scottmg for crashpad
> 
> I don't think there's any point to deleting the ones in third_party/crashpad
as
> they're just going to get rolled in again next time.

Okay, removed.

[brettw, 2016-09-13 22:45:37]

brettw@chromium.org changed reviewers:
- scottmg@chromium.org

[scottmg, 2016-09-13 22:50:26]

Also, yay! And I owe you a trophy.

[brettw, 2016-09-13 23:13:27]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-09-13 23:13:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2332843004/#ps40001
(title: "Put back crashpad gyp files")

[commit-bot: I haz the power, 2016-09-13 23:13:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam Clegg, 2016-09-13 23:15:15]

On 2016/09/13 23:13:51, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Wow!  A truly amazing achievement.  Wasn't sure I'd live to see the day :)

[Will Harris, 2016-09-13 23:19:16]

On 2016/09/13 23:13:51, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at

btw - third_party/widevine/cdm/widevine_cdm.gyp seems to still need an l-g-t-m
also is there a BUG for this?

[commit-bot: I haz the power, 2016-09-13 23:30:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 23:30:39]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2016-09-13 23:49:10]

On 2016/09/13 23:19:16, Will Harris wrote:
> On 2016/09/13 23:13:51, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> 
> btw - third_party/widevine/cdm/widevine_cdm.gyp seems to still need an l-g-t-m
> also is there a BUG for this?

I haven't been using tracking bugs for this work, it didn't seem like it would
help anything.

[brettw, 2016-09-13 23:50:01]

brettw@chromium.org changed reviewers:
+ ddorwin@chromium.org

[brettw, 2016-09-13 23:50:03]

+ddorwin for widevine

[ddorwin, 2016-09-14 00:07:26]

third_party/widevine/cdm/widevine_cdm.gyp LGTM!

[Dan Beam, 2016-09-14 05:30:40]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-09-14 05:30:42]

> not called "compiled_resources"

thank you!

unfortunately, i don't really know that's causing the closure_compilation
failure :(.  I wish I could be of more help.

build/gyp_chromium was the thing that customized GYP's behavior to change
out/Default (standard GYP dir, AFAICT) to out/{Debug,Release}.  maybe that's
been in flux lately?  that's what the try runs are barking about:
https://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compil...

thanks for your work here; GYP is almost gone!

[brettw, 2016-09-14 17:35:00]

Merge

[brettw, 2016-09-14 17:35:04]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 17:35:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 17:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 17:49:57]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[brettw, 2016-09-14 18:06:03]

I'm removing the closure_compilation trybot, it seems to just be broken (see
https://codereview.chromium.org/2341833002 for a whitespace test I sent to this
bot).

[brettw, 2016-09-14 18:06:25]

Description was changed from

==========
Remove GYP files.

This removes all .gyp files not called "compiled_resources" in the main Chromium
repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove GYP files.

This removes all .gyp files not called "compiled_resources" in the main Chromium
repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[Dirk Pranke, 2016-09-14 18:45:47]

On 2016/09/14 18:06:03, brettw (ping on IM after 24h) wrote:
> I'm removing the closure_compilation trybot, it seems to just be broken (see
> https://codereview.chromium.org/2341833002 for a whitespace test I sent to
this
> bot).

Hm. The builder is definitely sick, but not completely broken. I'll take a look.
I think
it's fine to land this w/o passing that trybot, but of course we may need to
revert this
change if we missed something.

[brettw, 2016-09-14 20:09:42]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-09-14 20:09:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, ddorwin@chromium.org
Link to the patchset: https://codereview.chromium.org/2332843004/#ps50001
(title: "Merge")

[commit-bot: I haz the power, 2016-09-14 20:10:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 20:21:17]

Description was changed from

==========
Remove GYP files.

This removes all .gyp files not called "compiled_resources" in the main Chromium
repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Remove GYP files.

This removes all .gyp files not called "compiled_resources" in the main Chromium
repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[commit-bot: I haz the power, 2016-09-14 20:21:20]

Committed patchset #6 (id:50001)

[commit-bot: I haz the power, 2016-09-14 20:23:29]

Description was changed from

==========
Remove GYP files.

This removes all .gyp files not called "compiled_resources" in the main Chromium
repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Remove GYP files.

This removes all .gyp files not called "compiled_resources" in the main Chromium
repository.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/315e4cfd4b1a120c3e2b28812afc5dbdc292bebe
Cr-Commit-Position: refs/heads/master@{#418654}
==========

[commit-bot: I haz the power, 2016-09-14 20:23:33]

Patchset 6 (id:??) landed as
https://crrev.com/315e4cfd4b1a120c3e2b28812afc5dbdc292bebe
Cr-Commit-Position: refs/heads/master@{#418654}

[Will Harris, 2016-09-14 20:25:29]

🎆 🎆!

[Dan Beam, 2016-09-14 20:40:59]

On 2016/09/14 18:45:47, Dirk Pranke wrote:
> On 2016/09/14 18:06:03, brettw (ping on IM after 24h) wrote:
> > I'm removing the closure_compilation trybot, it seems to just be broken (see
> > https://codereview.chromium.org/2341833002 for a whitespace test I sent to
> this
> > bot).
> 
> Hm. The builder is definitely sick, but not completely broken. I'll take a
look.
> I think
> it's fine to land this w/o passing that trybot, but of course we may need to
> revert this
> change if we missed something.

yes, I agree with your assessment, Brett.  it seems to be failing a lot right
now on missing out/Release (not related to this change, afaik).