Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2332843003: ValueSerializer: promote scheduled exception if the caller throws one. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ValueSerializer: promote scheduled exception if the caller throws one. v8::Isolate::Throw only schedules the exception; it is necessary to promote it after invoking the delegate. BUG=chromium:148757 Committed: https://crrev.com/3472b57a8f22e0ec686ad6f048263ea41780b423 Cr-Commit-Position: refs/heads/master@{#39395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/value-serializer.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jbroman
v8::Isolate::Throw (which delegates are likely to use) makes the thrown exception scheduled, not pending. Such ...
4 years, 3 months ago (2016-09-12 20:20:16 UTC) #6
Jakob Kummerow
lgtm
4 years, 3 months ago (2016-09-14 01:12:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332843003/1
4 years, 3 months ago (2016-09-14 01:30:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 02:04:56 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 02:05:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3472b57a8f22e0ec686ad6f048263ea41780b423
Cr-Commit-Position: refs/heads/master@{#39395}

Powered by Google App Engine
This is Rietveld 408576698