Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2332813002: SkPDF: do not assert when openStream return nullptr (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: do not assert when openStream return nullptr BUG=163892 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332813002 Committed: https://skia.googlesource.com/skia/+/2a4d1e1c1f574e3ee99ae0e3a47ef24f635b9b16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/pdf/SkPDFFont.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
hal.canary
4 years, 3 months ago (2016-09-12 15:00:21 UTC) #6
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-22 00:31:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332813002/1
4 years, 3 months ago (2016-09-22 20:42:42 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 21:13:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2a4d1e1c1f574e3ee99ae0e3a47ef24f635b9b16

Powered by Google App Engine
This is Rietveld 408576698