Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 23327003: Web Animations: Set the DocumentTimeline's zero time when the Document reaches the 'loading' phase (Closed)

Created:
7 years, 4 months ago by Steve Block
Modified:
7 years, 4 months ago
Reviewers:
dstockwell
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, Timothy Loh, dstockwell, dglazkov+blink, adamk+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Web Animations: Set the DocumentTimeline's zero time when the Document reaches the 'loading' phase It's possible for CSS animations to be created before the Document reaches the 'interactive' phase and we rely on the DocumentTimeline having a valid current time when the animation is created, Note that the new LayoutTest timeouts introduced here are due to a pre-existing bug with the generation of events for CSS animations. It seems that with this change we now hit this condition more frequently. A fix is coming soon. BUG=240653 R=dstockwell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156458

Patch Set 1 #

Patch Set 2 : Tweak LayoutTest expectations #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dstockwell
lgtm
7 years, 4 months ago (2013-08-20 06:38:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/23327003/1
7 years, 4 months ago (2013-08-20 06:43:49 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=2751
7 years, 4 months ago (2013-08-20 08:20:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/23327003/16001
7 years, 4 months ago (2013-08-21 00:47:20 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-21 04:05:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/23327003/16001
7 years, 4 months ago (2013-08-21 04:11:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/steveblock@chromium.org/23327003/30001
7 years, 4 months ago (2013-08-21 05:49:45 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-21 09:03:58 UTC) #8
Message was sent while issue was closed.
Change committed as 156458

Powered by Google App Engine
This is Rietveld 408576698