Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc

Issue 2332693003: Show media router toolbar icon ephemerally for active local routes and issues (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
diff --git a/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc b/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
index add326148d8fdc0946b0cd0b042734b593e8c412..4cdbec694ff423d5ddddd3854588aae9cf89934e 100644
--- a/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
+++ b/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <memory>
+
#include "base/macros.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/extensions/browser_action_test_util.h"
@@ -35,6 +37,7 @@ class MediaRouterContextualMenuUnitTest : public BrowserWithTestWindowTest {
SigninManagerBase* signin_manager() { return signin_manager_; }
ui::SimpleMenuModel* model() { return model_; }
+ MediaRouterAction* action() { return action_.get(); }
private:
std::unique_ptr<BrowserActionTestUtil> browser_action_test_util_;
@@ -96,7 +99,7 @@ TEST_F(MediaRouterContextualMenuUnitTest, Basic) {
TEST_F(MediaRouterContextualMenuUnitTest, ToggleCloudServicesItem) {
// The Media Router Action has a getter for the model, but not the delegate.
// Create the MediaRouterContextualMenu ui::SimpleMenuModel::Delegate here.
- MediaRouterContextualMenu menu(browser());
+ MediaRouterContextualMenu menu(browser(), action());
imcheng 2016/09/16 21:47:49 Could you add a test for the new option?
takumif 2016/09/20 14:50:46 Added a test.
// Set up an authenticated account such that the cloud services menu item is
// surfaced. Whether or not it is surfaced is tested in the "Basic" test.

Powered by Google App Engine
This is Rietveld 408576698