Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

Issue 2332693003: Show media router toolbar icon ephemerally for active local routes and issues (Closed)
Patch Set: Address Derek's comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
index 54d65de4e693b01cc01f3b4a0230349b087961e1..43a232f2c6f8f405d0faf2f9bca2258c7c7b6399 100644
--- a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
+++ b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
@@ -1312,36 +1312,6 @@ TEST_F(ToolbarActionsModelUnitTest, ToolbarModelPrefChange) {
observer()->inserted_count() - observer()->removed_count());
}
-TEST_F(ToolbarActionsModelUnitTest, ComponentExtensionsAddedToEnd) {
- Init();
-
- ASSERT_TRUE(AddBrowserActionExtensions());
-
- EXPECT_EQ(browser_action_a()->id(), GetActionIdAtIndex(0));
- EXPECT_EQ(browser_action_b()->id(), GetActionIdAtIndex(1));
- EXPECT_EQ(browser_action_c()->id(), GetActionIdAtIndex(2));
-
- const char kName[] = "component";
- extensions::DictionaryBuilder manifest;
- manifest.Set("name", kName)
- .Set("description", "An extension")
- .Set("manifest_version", 2)
- .Set("version", "1.0.0")
- .Set("browser_action", extensions::DictionaryBuilder().Build());
- scoped_refptr<const extensions::Extension> component_extension =
- extensions::ExtensionBuilder()
- .SetManifest(manifest.Build())
- .SetID(crx_file::id_util::GenerateId(kName))
- .SetLocation(extensions::Manifest::COMPONENT)
- .Build();
- service()->AddExtension(component_extension.get());
-
- EXPECT_EQ(component_extension.get()->id(), GetActionIdAtIndex(0));
- EXPECT_EQ(browser_action_a()->id(), GetActionIdAtIndex(1));
- EXPECT_EQ(browser_action_b()->id(), GetActionIdAtIndex(2));
- EXPECT_EQ(browser_action_c()->id(), GetActionIdAtIndex(3));
-}
-
// Test various different reorderings, removals, and reinsertions of the
// toolbar with component actions.
TEST_F(ToolbarActionsModelUnitTest,

Powered by Google App Engine
This is Rietveld 408576698