Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Unified Diff: chrome/browser/media/router/media_router_ui_service_factory_unittest.cc

Issue 2332693003: Show media router toolbar icon ephemerally for active local routes and issues (Closed)
Patch Set: Free memory in MRUIServiceFactoryUnitTest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_router_ui_service_factory_unittest.cc
diff --git a/chrome/browser/media/router/media_router_ui_service_factory_unittest.cc b/chrome/browser/media/router/media_router_ui_service_factory_unittest.cc
index 2fb56b6a0a9f8f959dd1778f9fd97692bfc4dc67..09d5f192bb60bb0bfb053e873b4fecb9a154a355 100644
--- a/chrome/browser/media/router/media_router_ui_service_factory_unittest.cc
+++ b/chrome/browser/media/router/media_router_ui_service_factory_unittest.cc
@@ -44,9 +44,14 @@ class MediaRouterUIServiceFactoryUnitTest : public testing::Test {
};
TEST_F(MediaRouterUIServiceFactoryUnitTest, CreateService) {
- MediaRouterUIService* service =
- MediaRouterUIServiceFactory::GetForBrowserContext(profile());
+ // We call BuildServiceInstanceFor() directly because
+ // MediaRouterUIServiceFactory::GetForBrowserContext() is set to return a
+ // nullptr for a test profile.
+ MediaRouterUIService* service = static_cast<MediaRouterUIService*>(
imcheng 2016/09/21 23:45:38 nit: You can use unique_ptr<> so you don't have to
takumif 2016/09/21 23:53:12 Done.
+ MediaRouterUIServiceFactory::GetInstance()->BuildServiceInstanceFor(
+ profile()));
ASSERT_TRUE(service);
+ delete service;
}
} // namespace media_router
« no previous file with comments | « chrome/browser/media/router/media_router_ui_service_factory.cc ('k') | chrome/browser/ui/toolbar/media_router_action.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698