chrome/browser/media/router/media_router_ui_service_factory_unittest.cc - Issue 2332693003: Show media router toolbar icon ephemerally for active local routes and issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/media_router_ui_service_factory_unittest.cc

Issue 2332693003: Show media router toolbar icon ephemerally for active local routes and issues (Closed)

Patch Set: Address Devlin's comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/media_router_ui_service_factory.cc ('k') | chrome/browser/ui/toolbar/media_router_action.h » ('j') | chrome/browser/ui/toolbar/media_router_action.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/media_router_ui_service_factory_unittest.cc

diff --git a/chrome/browser/media/router/media_router_ui_service_factory_unittest.cc b/chrome/browser/media/router/media_router_ui_service_factory_unittest.cc

index 2fb56b6a0a9f8f959dd1778f9fd97692bfc4dc67..24b407b77d76ac8561c953b8ac941e7b6b25870b 100644

--- a/chrome/browser/media/router/media_router_ui_service_factory_unittest.cc

+++ b/chrome/browser/media/router/media_router_ui_service_factory_unittest.cc

@@ -44,8 +44,12 @@ class MediaRouterUIServiceFactoryUnitTest : public testing::Test {

};

TEST_F(MediaRouterUIServiceFactoryUnitTest, CreateService) {

- MediaRouterUIService* service =

- MediaRouterUIServiceFactory::GetForBrowserContext(profile());

+ // We call BuildServiceInstanceFor() directly because

+ // MediaRouterUIServiceFactory::GetForBrowserContext() is set to return a

+ // nullptr for a test profile.

+ MediaRouterUIService* service = static_cast<MediaRouterUIService*>(

+ MediaRouterUIServiceFactory::GetInstance()->BuildServiceInstanceFor(

+ profile()));

ASSERT_TRUE(service);

}