chrome/browser/media/router/media_router_ui_service.cc - Issue 2332693003: Show media router toolbar icon ephemerally for active local routes and issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/media_router_ui_service.cc

Issue 2332693003: Show media router toolbar icon ephemerally for active local routes and issues (Closed)

Patch Set: Address Derek and Mike's comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/router/media_router_ui_service.cc

diff --git a/chrome/browser/media/router/media_router_ui_service.cc b/chrome/browser/media/router/media_router_ui_service.cc

index e26eb18aae284eacf4644e56ecfd21945614e4c1..98cb3e60a05c9432dac08b67bf3361be05388084 100644

--- a/chrome/browser/media/router/media_router_ui_service.cc

+++ b/chrome/browser/media/router/media_router_ui_service.cc

@@ -11,9 +11,7 @@

namespace media_router {

MediaRouterUIService::MediaRouterUIService(Profile* profile)

- : action_controller_(profile) {

- DCHECK(media_router::MediaRouterEnabled(profile));

+ : action_controller_(profile) {}

takumif 2016/09/20 14:50:47 Cannot DCHECK here because it makes MediaRouterDis

MediaRouterUIService::~MediaRouterUIService() {}