chrome/browser/ui/toolbar/component_toolbar_actions_factory.h - Issue 2332693003: Show media router toolbar icon ephemerally for active local routes and issues

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/toolbar/component_toolbar_actions_factory.h

Issue 2332693003: Show media router toolbar icon ephemerally for active local routes and issues (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/app/media_router_strings.grdp ('K') | « chrome/app/media_router_strings.grdp ('k') | chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc » ('j') | chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_	5 #ifndef CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_

6 #define CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_	6 #define CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_

7	7

8 #include <memory>	8 #include <memory>

9 #include <set>	9 #include <set>

10 #include <string>	10 #include <string>

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45	45

46 // Registers component actions that are migrating from extensions.	46 // Registers component actions that are migrating from extensions.

47 virtual void RegisterComponentMigrations(	47 virtual void RegisterComponentMigrations(

48 extensions::ComponentMigrationHelper* helper) const;	48 extensions::ComponentMigrationHelper* helper) const;

49	49

50 // Synchronizes component action visibility and extension install status.	50 // Synchronizes component action visibility and extension install status.

51 virtual void HandleComponentMigrations(	51 virtual void HandleComponentMigrations(

52 extensions::ComponentMigrationHelper* helper,	52 extensions::ComponentMigrationHelper* helper,

53 Profile* profile) const;	53 Profile* profile) const;

54	54

	55 virtual void InitializeComponentActionControllers(Profile* profile);
	Devlin 2016/09/15 21:19:17 add function comment add function comment takumif 2016/09/16 21:19:22 Replacing this with ServiceIsCreatedWithBrowserCon Show quoted text On 2016/09/15 21:19:17, Devlin wrote: > add function comment Replacing this with ServiceIsCreatedWithBrowserContext(). imcheng 2016/09/16 21:47:48 This doesn't need to be virtual unless you are ove This doesn't need to be virtual unless you are overriding it in the mock version?
	56

55 // Sets the factory to use for testing purposes.	57 // Sets the factory to use for testing purposes.

56 // Ownership remains with the caller.	58 // Ownership remains with the caller.

57 static void SetTestingFactory(ComponentToolbarActionsFactory* factory);	59 static void SetTestingFactory(ComponentToolbarActionsFactory* factory);

58	60

59 private:	61 private:

60 DISALLOW_COPY_AND_ASSIGN(ComponentToolbarActionsFactory);	62 DISALLOW_COPY_AND_ASSIGN(ComponentToolbarActionsFactory);

61 };	63 };

62	64

63 #endif // CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_	65 #endif // CHROME_BROWSER_UI_TOOLBAR_COMPONENT_TOOLBAR_ACTIONS_FACTORY_H_

OLD	NEW