Show media router toolbar icon ephemerally for active local routes and issues

chrome/browser/media/router/media_router_ui_service_factory.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/router/media_router_ui_service_factory.h"
 
 #include "chrome/browser/media/router/media_router_factory.h"
 #include "chrome/browser/media/router/media_router_ui_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/toolbar/toolbar_actions_model_factory.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 
 using content::BrowserContext;
 
+namespace {
+bool use_in_tests = false;
+}
+
 namespace media_router {
 
 // static
 MediaRouterUIService* MediaRouterUIServiceFactory::GetForBrowserContext(
     BrowserContext* context) {
   DCHECK(context);
   return static_cast<MediaRouterUIService*>(
       GetInstance()->GetServiceForBrowserContext(context, true));
 }
 
 // static
 MediaRouterUIServiceFactory* MediaRouterUIServiceFactory::GetInstance() {
   return base::Singleton<MediaRouterUIServiceFactory>::get();
 }
 
+// static
+void MediaRouterUIServiceFactory::SetUseInTests() {
+  use_in_tests = true;

[Devlin, 2016/09/20 21:55:48]

Drive-by: this is a little unconventional (and is also never reset, which is bad
for globals in unittests).  What about using SetTestingFactoryAndUse() instead?

[takumif, 2016/09/20 23:38:10]

Changed to calling BuildServiceInstanceFor() directly.

+}
+
 MediaRouterUIServiceFactory::MediaRouterUIServiceFactory()
     : BrowserContextKeyedServiceFactory(
           "MediaRouterUIService",
           BrowserContextDependencyManager::GetInstance()) {
   DependsOn(MediaRouterFactory::GetInstance());
   // MediaRouterUIService owns a MediaRouterActionController that depends on
   // ToolbarActionsModel.
   DependsOn(ToolbarActionsModelFactory::GetInstance());
 }
 
 MediaRouterUIServiceFactory::~MediaRouterUIServiceFactory() {}
 
 BrowserContext* MediaRouterUIServiceFactory::GetBrowserContextToUse(
     BrowserContext* context) const {
   return context;
 }
 
 KeyedService* MediaRouterUIServiceFactory::BuildServiceInstanceFor(
     BrowserContext* context) const {
   return new MediaRouterUIService(Profile::FromBrowserContext(context));
 }
 
+bool MediaRouterUIServiceFactory::ServiceIsCreatedWithBrowserContext() const {
+#if defined(ENABLE_MEDIA_ROUTER) && !defined(OS_ANDROID)
+  return true;
+#else
+  return false;
+#endif
+}
+
+bool MediaRouterUIServiceFactory::ServiceIsNULLWhileTesting() const {
+  return !use_in_tests;
+}
+
 }  // namespace media_router