net/url_request/url_request_http_job.cc - Issue 2332643002: Change net/nqe and some url_request tests to use new URLRequest API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_http_job.cc

Issue 2332643002: Change net/nqe and some url_request tests to use new URLRequest API (Closed)

Patch Set: add ftp job unittests and http job files Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_http_job.cc

diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc

index 7ee8cddc610d583e778bbcdff3de10e740023a50..e7c7ba97dc86bc6a0331b395c6798432f1bb737c 100644

--- a/net/url_request/url_request_http_job.cc

+++ b/net/url_request/url_request_http_job.cc

@@ -1587,7 +1587,8 @@ void URLRequestHttpJob::DoneWithRequest(CompletionCause reason) {

NetworkQualityEstimator* network_quality_estimator =

request()->context()->network_quality_estimator();

if (network_quality_estimator)

- network_quality_estimator->NotifyRequestCompleted(*request());

+ network_quality_estimator->NotifyRequestCompleted(

+ *request(), request_->status().error());

}

RecordPerfHistograms(reason);