Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2332633002: [turbofan] Another fix for induction variable typing monotonicity. (Closed)

Created:
4 years, 3 months ago by Jarin
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Another fix for induction variable typing monotonicity. BUG=chromium:645851 Committed: https://crrev.com/e031451cd72289bd5fc81197fb831bb6121b298c Cr-Commit-Position: refs/heads/master@{#39358}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M src/compiler/typer.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + test/mjsunit/compiler/regress-645851.js View 1 chunk +9 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Jarin
Could you take a look, please?
4 years, 3 months ago (2016-09-12 04:41:19 UTC) #2
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-12 04:41:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332633002/1
4 years, 3 months ago (2016-09-12 17:03:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 17:04:52 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 17:05:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e031451cd72289bd5fc81197fb831bb6121b298c
Cr-Commit-Position: refs/heads/master@{#39358}

Powered by Google App Engine
This is Rietveld 408576698