ppapi/native_client/src/trusted/plugin/plugin_error.h - Issue 23326003: Enable PNaCl by default (revert disabling CL)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin_error.h

Issue 23326003: Enable PNaCl by default (revert disabling CL) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes for Jan's comments. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/native_client/src/trusted/plugin/plugin_error.h

diff --git a/ppapi/native_client/src/trusted/plugin/plugin_error.h b/ppapi/native_client/src/trusted/plugin/plugin_error.h

index cba1701c6cdbdb230905ef4d8bfffd6c72289159..4ec0b51a9e06e5c2df4b824c6e79872eebec641f 100644

--- a/ppapi/native_client/src/trusted/plugin/plugin_error.h

+++ b/ppapi/native_client/src/trusted/plugin/plugin_error.h

@@ -93,8 +93,8 @@ enum PluginErrorCode {

ERROR_PNACL_LLC_INTERNAL = 65,

ERROR_PNACL_LD_INTERNAL = 66,

ERROR_PNACL_CREATE_TEMP = 67,

- // Remove this next code when pnacl is no longer behind a flag (when we

- // remove the --enable-pnacl flag).

+ // This entry is no longer used, but should not be removed, because UMA

+ // numbers need to be kept consistent.

ERROR_PNACL_NOT_ENABLED = 68,

ERROR_MANIFEST_NOACCESS_URL = 69,

ERROR_NEXE_NOACCESS_URL = 70,