Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7108)

Unified Diff: chrome/test/nacl/nacl_browsertest_util.h

Issue 23326003: Enable PNaCl by default (revert disabling CL) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes for Jan's comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/nacl/nacl_browsertest_uma.cc ('k') | chrome/test/nacl/nacl_browsertest_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/nacl/nacl_browsertest_util.h
diff --git a/chrome/test/nacl/nacl_browsertest_util.h b/chrome/test/nacl/nacl_browsertest_util.h
index 42e27ce9bc7a502efe874eb2ee89c41eadf53b4c..27e638b02e47a23e85d475b01469f892ff2ca5c4 100644
--- a/chrome/test/nacl/nacl_browsertest_util.h
+++ b/chrome/test/nacl/nacl_browsertest_util.h
@@ -74,7 +74,9 @@ class NaClBrowserTestBase : public InProcessBrowserTest {
// Where are the files for this class of test located on disk?
virtual bool GetDocumentRoot(base::FilePath* document_root);
- virtual bool IsPnacl();
+ virtual bool IsAPnaclTest();
+
+ virtual bool IsPnaclDisabled();
// Map a file relative to the variant directory to a URL served by the test
// web server.
@@ -116,11 +118,22 @@ class NaClBrowserTestGLibc : public NaClBrowserTestBase {
class NaClBrowserTestPnacl : public NaClBrowserTestBase {
public:
+ virtual base::FilePath::StringType Variant() OVERRIDE;
+
+ virtual bool IsAPnaclTest() OVERRIDE;
+};
+
+// Class used to test that when --disable-pnacl is specified the PNaCl mime
+// type is not available.
+class NaClBrowserTestPnaclDisabled : public NaClBrowserTestBase {
+ public:
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE;
virtual base::FilePath::StringType Variant() OVERRIDE;
- virtual bool IsPnacl() OVERRIDE;
+ virtual bool IsAPnaclTest() OVERRIDE;
+
+ virtual bool IsPnaclDisabled() OVERRIDE;
};
// Temporary class for running tests with the old cache enabled. Once all the
@@ -155,7 +168,7 @@ body
#else
-// Otherwise, we have Glibc, Newlib and PNaCl tests
+// Otherwise, we have Glibc, Newlib and Pnacl tests
#define NACL_BROWSER_TEST_F(suite, name, body) \
IN_PROC_BROWSER_TEST_F(suite##Newlib, name) \
body \
« no previous file with comments | « chrome/test/nacl/nacl_browsertest_uma.cc ('k') | chrome/test/nacl/nacl_browsertest_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698