Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2332493002: Revert of Move more sources from modules.gypi to subdirectories. (Closed)

Created:
4 years, 3 months ago by dmurph
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, dominickn+watch_chromium.org, dshwang, eric.carlson_apple.com, scheib+watch_chromium.org, ortuno+watch_chromium.org, dmazzoni+watch_chromium.org, je_julie, Srirama, aboxhall, aboxhall+watch_chromium.org, chasej+watch_chromium.org, Justin Novosad, Rik, jkarlin+watch_chromium.org, blink-reviews, ajuma+watch-canvas_chromium.org, Peter Beverloo, timvolodine, feature-media-reviews_chromium.org, dmazzoni, yuzo+watch_chromium.org, haraken, mlamouri+watch-blink_chromium.org, nektar+watch_chromium.org, iclelland+watch_chromium.org, nektarios, dtseng+watch_chromium.org, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move more sources from modules.gypi to subdirectories. (patchset #2 id:20001 of https://codereview.chromium.org/2324803006/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=645621 BUG=645621 Original issue's description: > Move more sources from modules.gypi to subdirectories. > > More classes of Blink modules are moved from the deprecated modules.gypi to separate BUILD files in the module directories. > > TBR=dpranke@chromium.org > > Committed: https://crrev.com/9ce4e475c115bd1e473bb02f6cab81d767586ac9 > Cr-Commit-Position: refs/heads/master@{#417700} TBR=dpranke@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -567 lines) Patch
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +1 line, -22 lines 0 comments Download
D third_party/WebKit/Source/modules/accessibility/BUILD.gn View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/Source/modules/app_banner/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/modules/audio_output_devices/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/modules/background_sync/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/modules/battery/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/modules/beacon/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/modules/bluetooth/BUILD.gn View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/modules/broadcastchannel/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/modules/budget/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/modules/cachestorage/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/Source/modules/canvas/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/modules/canvas2d/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/Source/modules/compositorworker/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/modules/credentialmanager/BUILD.gn View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/modules/crypto/BUILD.gn View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/Source/modules/csspaint/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/modules/device_orientation/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/Source/modules/donottrack/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/modules/encoding/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/modules/encryptedmedia/BUILD.gn View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/modules/fetch/BUILD.gn View 1 chunk +0 lines, -54 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +321 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dmurph
Created Revert of Move more sources from modules.gypi to subdirectories.
4 years, 3 months ago (2016-09-10 01:34:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332493002/1
4 years, 3 months ago (2016-09-10 01:35:11 UTC) #3
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/modules/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
4 years, 3 months ago (2016-09-10 01:35:41 UTC) #5
brettw
4 years, 3 months ago (2016-09-10 02:39:06 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698