Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1752)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

Issue 2332483002: [CUPS] Implement the CUPS printer PPD file picker in the manufacturer and model dialog. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
diff --git a/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js b/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
index d53eb12854981bcf1e8ffe7e89717e1fa2181891..e7a64aef905d4237f4a471d4c96dc852a2184e21 100644
--- a/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
+++ b/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
@@ -17,7 +17,8 @@
* printerStatus: string,
* printerAddress: string,
* printerProtocol: string,
- * printerQueue: string
+ * printerQueue: string,
+ * printerPPDPath: string
michaelpg 2016/09/15 03:01:39 alpha?
xdai1 2016/09/16 21:19:32 Done.
* }}
*/
var CupsPrinterInfo;
@@ -51,6 +52,10 @@ cr.define('settings', function() {
*/
removeCupsPrinter: function(printerId) {},
+ /**
+ * @return {!Promise<string>} the full path of the printer PPD file.
michaelpg 2016/09/15 03:01:39 capitalize description
xdai1 2016/09/16 21:19:32 Done.
+ */
+ getCupsPrinterPPDPath: function() {},
};
/**
@@ -61,20 +66,25 @@ cr.define('settings', function() {
cr.addSingletonGetter(CupsPrintersBrowserProxyImpl);
CupsPrintersBrowserProxyImpl.prototype = {
- /** override */
+ /** @override */
getCupsPrintersList: function() {
return cr.sendWithPromise('getCupsPrintersList');
},
- /** override */
+ /** @override */
updateCupsPrinter: function(printerId, printerName) {
chrome.send('updateCupsPrinter', [printerId, printerName]);
},
- /** override */
+ /** @override */
removeCupsPrinter: function(printerId) {
chrome.send('removeCupsPrinter', [printerId]);
},
+
+ /** @override */
+ getCupsPrinterPPDPath: function() {
+ return cr.sendWithPromise('selectPPDFile');
+ },
};
return {

Powered by Google App Engine
This is Rietveld 408576698