Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 233243005: Do not call user defined getter of Error.stackTraceLimit. (Closed)

Created:
6 years, 8 months ago by ulan
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Do not call user defined getter of Error.stackTraceLimit. Handlify GetNormalizedProperty. BUG=360733 LOG=N R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20691

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fix test #

Patch Set 4 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -29 lines) Patch
M src/isolate.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +49 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +2 lines, -22 lines 0 comments Download
A + test/mjsunit/regress/regress-360733.js View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ulan
PTAL
6 years, 8 months ago (2014-04-11 12:49:03 UTC) #1
Yang
LGTM with nit. https://codereview.chromium.org/233243005/diff/10001/test/mjsunit/regress/regress-360733.js File test/mjsunit/regress/regress-360733.js (right): https://codereview.chromium.org/233243005/diff/10001/test/mjsunit/regress/regress-360733.js#newcode9 test/mjsunit/regress/regress-360733.js:9: __f_9(0); I would rename/reformat this to ...
6 years, 8 months ago (2014-04-11 12:53:29 UTC) #2
ulan
https://codereview.chromium.org/233243005/diff/10001/test/mjsunit/regress/regress-360733.js File test/mjsunit/regress/regress-360733.js (right): https://codereview.chromium.org/233243005/diff/10001/test/mjsunit/regress/regress-360733.js#newcode9 test/mjsunit/regress/regress-360733.js:9: __f_9(0); On 2014/04/11 12:53:30, Yang wrote: > I would ...
6 years, 8 months ago (2014-04-11 12:55:12 UTC) #3
Yang
On 2014/04/11 12:55:12, ulan wrote: > https://codereview.chromium.org/233243005/diff/10001/test/mjsunit/regress/regress-360733.js > File test/mjsunit/regress/regress-360733.js (right): > > https://codereview.chromium.org/233243005/diff/10001/test/mjsunit/regress/regress-360733.js#newcode9 > ...
6 years, 8 months ago (2014-04-11 13:13:38 UTC) #4
ulan
6 years, 8 months ago (2014-04-11 13:17:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 manually as r20691 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698