|
|
Created:
4 years, 3 months ago by Charlie Harrison Modified:
4 years, 3 months ago CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, kouhei (in TOK) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove old prefetcher histogram code
The histograms are obsolete, and this code walks the frame tree!
BUG=595742
Committed: https://crrev.com/0118e63731d7b195258c64fefc1efbc8e44ef35b
Cr-Commit-Position: refs/heads/master@{#418874}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : proper rebase :P #Patch Set 4 : Remove old prefetcher histogram code #
Messages
Total messages: 38 (25 generated)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove old prefetcher histogram code The histograms are obsolete. ========== to ========== Remove old prefetcher histogram code The histograms are obsolete, and this code walks the frame tree! ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
csharrison@chromium.org changed reviewers: + gavinp@chromium.org
Gavin, can we safely remove this code?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
csharrison@chromium.org changed reviewers: + creis@chromium.org
+creis, for content OWNERS and removing a TODO (is it just referring to the histograms)?
cc kouhei for loader refactoring work.
kouhei@chromium.org changed reviewers: + kouhei@chromium.org
Wow! Thanks for this clean up.
Fantastic! LGTM if no other code needed that state on DocumentState. Is there a bug number you can list in the CL description for prefetch histograms being obsolete? I don't have the context to verify that. On 2016/09/13 22:45:58, Charlie Harrison wrote: > +creis, for content OWNERS and removing a TODO (is it just referring to the > histograms)? I didn't realize that code was only for the histogram when I added the TODO. If so, I'm happy to have it removed!
On 2016/09/14 19:29:48, Charlie Reis (slow) wrote: > Fantastic! LGTM if no other code needed that state on DocumentState. > > Is there a bug number you can list in the CL description for prefetch histograms > being obsolete? I don't have the context to verify that. > > On 2016/09/13 22:45:58, Charlie Harrison wrote: > > +creis, for content OWNERS and removing a TODO (is it just referring to the > > histograms)? > > I didn't realize that code was only for the histogram when I added the TODO. If > so, I'm happy to have it removed! The histograms were deprecated in crbug.com/595742, which more generally deprecated all old PLT metrics. I can add that as a BUG= but it is a very general issue, and these metrics have been unowned since 2014.
I believe this is fine to remove; if we ever intensively watch prerender metrics we'll want it again though.
lgtm
csharrison@chromium.org changed reviewers: + bmcquade@chromium.org
Thanks, yeah that's my impression too. Finally, +bmcquade for removal from page_load_histograms.cc
On 2016/09/15 at 13:22:06, csharrison wrote: > Thanks, yeah that's my impression too. > > Finally, +bmcquade for removal from page_load_histograms.cc LGTM, thanks for removing this code!
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove old prefetcher histogram code The histograms are obsolete, and this code walks the frame tree! ========== to ========== Remove old prefetcher histogram code The histograms are obsolete, and this code walks the frame tree! BUG=595742 ==========
Message was sent while issue was closed.
Description was changed from ========== Remove old prefetcher histogram code The histograms are obsolete, and this code walks the frame tree! BUG=595742 ========== to ========== Remove old prefetcher histogram code The histograms are obsolete, and this code walks the frame tree! BUG=595742 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Remove old prefetcher histogram code The histograms are obsolete, and this code walks the frame tree! BUG=595742 ========== to ========== Remove old prefetcher histogram code The histograms are obsolete, and this code walks the frame tree! BUG=595742 Committed: https://crrev.com/0118e63731d7b195258c64fefc1efbc8e44ef35b Cr-Commit-Position: refs/heads/master@{#418874} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0118e63731d7b195258c64fefc1efbc8e44ef35b Cr-Commit-Position: refs/heads/master@{#418874} |