Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2332423003: Remove old prefetcher histogram code in render_frame_impl (Closed)

Created:
4 years, 3 months ago by Charlie Harrison
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, kouhei (in TOK)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old prefetcher histogram code The histograms are obsolete, and this code walks the frame tree! BUG=595742 Committed: https://crrev.com/0118e63731d7b195258c64fefc1efbc8e44ef35b Cr-Commit-Position: refs/heads/master@{#418874}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : proper rebase :P #

Patch Set 4 : Remove old prefetcher histogram code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -75 lines) Patch
M chrome/renderer/page_load_histograms.cc View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M content/public/renderer/document_state.h View 1 2 3 2 chunks +0 lines, -19 lines 0 comments Download
M content/public/renderer/document_state.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 38 (25 generated)
Charlie Harrison
Gavin, can we safely remove this code?
4 years, 3 months ago (2016-09-13 21:34:58 UTC) #17
Charlie Harrison
+creis, for content OWNERS and removing a TODO (is it just referring to the histograms)?
4 years, 3 months ago (2016-09-13 22:45:58 UTC) #21
Charlie Harrison
cc kouhei for loader refactoring work.
4 years, 3 months ago (2016-09-14 16:28:29 UTC) #22
kouhei (in TOK)
Wow! Thanks for this clean up.
4 years, 3 months ago (2016-09-14 16:40:01 UTC) #24
Charlie Reis
Fantastic! LGTM if no other code needed that state on DocumentState. Is there a bug ...
4 years, 3 months ago (2016-09-14 19:29:48 UTC) #25
Charlie Harrison
On 2016/09/14 19:29:48, Charlie Reis (slow) wrote: > Fantastic! LGTM if no other code needed ...
4 years, 3 months ago (2016-09-14 20:08:22 UTC) #26
gavinp
I believe this is fine to remove; if we ever intensively watch prerender metrics we'll ...
4 years, 3 months ago (2016-09-15 13:20:35 UTC) #27
gavinp
lgtm
4 years, 3 months ago (2016-09-15 13:20:46 UTC) #28
Charlie Harrison
Thanks, yeah that's my impression too. Finally, +bmcquade for removal from page_load_histograms.cc
4 years, 3 months ago (2016-09-15 13:22:06 UTC) #30
Bryan McQuade
On 2016/09/15 at 13:22:06, csharrison wrote: > Thanks, yeah that's my impression too. > > ...
4 years, 3 months ago (2016-09-15 14:34:14 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332423003/60001
4 years, 3 months ago (2016-09-15 14:52:37 UTC) #33
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-15 15:41:31 UTC) #36
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 15:43:25 UTC) #38
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0118e63731d7b195258c64fefc1efbc8e44ef35b
Cr-Commit-Position: refs/heads/master@{#418874}

Powered by Google App Engine
This is Rietveld 408576698