Added memory-monitor for ChromeOS.

Added memory-monitor for ChromeOS.

BUG=644397
Committed: https://crrev.com/98900b02d86546533cfcb95356db7d327bb31204
Cr-Commit-Position: refs/heads/master@{#419544}

[bcwhite, 2016-09-13 18:11:24]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 18:12:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:20:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 19:20:37]

Dry run: This issue passed the CQ dry run.

[bcwhite, 2016-09-13 19:54:38]

bcwhite@chromium.org changed reviewers:
+ chrisha@chromium.org

[chrisha, 2016-09-14 09:53:34]

short and sweet!

lgtm

https://codereview.chromium.org/2332423002/diff/1/components/memory_coordinat...
File components/memory_coordinator/browser/BUILD.gn (right):

https://codereview.chromium.org/2332423002/diff/1/components/memory_coordinat...
components/memory_coordinator/browser/BUILD.gn:17: "memory_monitor_chromeos.cc",
The automagic source-file filtering doesn't work for _chromeos files?

/sadface

[bcwhite, 2016-09-14 13:19:27]

https://codereview.chromium.org/2332423002/diff/1/components/memory_coordinat...
File components/memory_coordinator/browser/BUILD.gn (right):

https://codereview.chromium.org/2332423002/diff/1/components/memory_coordinat...
components/memory_coordinator/browser/BUILD.gn:17: "memory_monitor_chromeos.cc",
On 2016/09/14 09:53:34, chrisha (OOO til 26 Sep) wrote:
> The automagic source-file filtering doesn't work for _chromeos files?
> 
> /sadface

It does...  but it also includes the _linux files which meant for dead code and
a duplicate static Create() method.

[bcwhite, 2016-09-15 10:49:30]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2016-09-15 10:49:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 10:52:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 10:52:03]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[bcwhite, 2016-09-19 13:21:16]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 13:21:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2016-09-19 13:57:36]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 13:57:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2016-09-19 14:22:22]

The CQ bit was unchecked by bcwhite@chromium.org

[bcwhite, 2016-09-19 14:22:26]

The CQ bit was checked by bcwhite@chromium.org

[bcwhite, 2016-09-19 14:22:27]

The patchset sent to the CQ was uploaded after l-g-t-m from chrisha@chromium.org
Link to the patchset: https://codereview.chromium.org/2332423002/#ps40001
(title: "limit conditionals to only chromeos/linux (win, mac, etc. are
automatic)")

[commit-bot: I haz the power, 2016-09-19 14:22:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 14:30:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 14:30:31]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bcwhite, 2016-09-19 14:36:22]

bcwhite@chromium.org changed reviewers:
+ nasko@chromium.org

[bcwhite, 2016-09-19 14:36:22]

nasko@chromium.org: Please review changes in 

*/BUILD.gn

[nasko, 2016-09-19 17:05:05]

LGTM

https://codereview.chromium.org/2332423002/diff/40001/content/browser/BUILD.gn
File content/browser/BUILD.gn (right):

https://codereview.chromium.org/2332423002/diff/40001/content/browser/BUILD.g...
content/browser/BUILD.gn:1384: # Chromeos also defines linux but their
memory-monitors conflict.
nit: ChromeOS

https://codereview.chromium.org/2332423002/diff/40001/content/test/BUILD.gn
File content/test/BUILD.gn (right):

https://codereview.chromium.org/2332423002/diff/40001/content/test/BUILD.gn#n...
content/test/BUILD.gn:1322: # Chromeos also defines linux but their
memory-monitors conflict.
nit: ChromeOS

[bcwhite, 2016-09-19 19:31:14]

The CQ bit was checked by bcwhite@chromium.org

[bcwhite, 2016-09-19 19:31:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrisha@chromium.org, nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2332423002/#ps60001
(title: "fixed name of ChromeOS")

[commit-bot: I haz the power, 2016-09-19 19:32:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 20:13:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-19 21:03:28]

Description was changed from

==========
Added memory-monitor for ChromeOS.

BUG=644397
==========

to

==========
Added memory-monitor for ChromeOS.

BUG=644397

Committed: https://crrev.com/98900b02d86546533cfcb95356db7d327bb31204
Cr-Commit-Position: refs/heads/master@{#419544}
==========

[commit-bot: I haz the power, 2016-09-19 21:03:29]

Patchset 4 (id:??) landed as
https://crrev.com/98900b02d86546533cfcb95356db7d327bb31204
Cr-Commit-Position: refs/heads/master@{#419544}