Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2332353004: Mojo C++ bindings: support closing [Associated]InterfaceRequest with reason. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: support closing [Associated]InterfaceRequest with reason. BUG=634502 Committed: https://crrev.com/555aa69be8ac5b5138cf6a89a7adf32d824fcb15 Cr-Commit-Position: refs/heads/master@{#418382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -25 lines) Patch
M mojo/public/cpp/bindings/associated_interface_request.h View 2 chunks +28 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/interface_request.h View 2 chunks +17 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_proxy.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_proxy.cc View 6 chunks +39 lines, -22 lines 0 comments Download
M mojo/public/cpp/bindings/tests/associated_interface_unittest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2318793002 Patch 100001

Messages

Total messages: 12 (7 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 3 months ago (2016-09-13 18:11:07 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-09-13 21:38:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332353004/1
4 years, 3 months ago (2016-09-13 21:44:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 21:50:26 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 21:53:19 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/555aa69be8ac5b5138cf6a89a7adf32d824fcb15
Cr-Commit-Position: refs/heads/master@{#418382}

Powered by Google App Engine
This is Rietveld 408576698