third_party/WebKit/Source/core/fetch/ResourceFetcher.h - Issue 2332333003: Make internals.isPreloaded() to remain the same before/after clearPreloads()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcher.h

Issue 2332333003: Make internals.isPreloaded() to remain the same before/after clearPreloads() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Allow preloads before enableIsPreloadedForTest() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/preloader/is-preloaded-after-load.html ('K') | « third_party/WebKit/LayoutTests/fast/preloader/is-preloaded-after-load-expected.txt ('k') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/ResourceFetcher.h

diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

index 847ce9e077d904310327c9ab0cf57a979bcff074..52a02be8f15623feede02887e52c5cd9037e0f6c 100644

--- a/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

@@ -94,7 +94,9 @@ public:

enum ClearPreloadsPolicy { ClearAllPreloads, ClearSpeculativeMarkupPreloads };

- bool isPreloaded(const KURL&) const;

+ void enableIsPreloadedForTest();

+ bool isPreloadedForTest(const KURL&) const;

int countPreloads() const { return m_preloads ? m_preloads->size() : 0; }

void clearPreloads(ClearPreloadsPolicy = ClearAllPreloads);

void preloadStarted(Resource*);

@@ -208,6 +210,8 @@ private:

};

DeadResourceStatsRecorder m_deadStatsRecorder;

+ std::unique_ptr<HashSet<String>> m_preloadedURLsForTest;

// 28 bits left

bool m_autoLoadImages : 1;

bool m_imagesEnabled : 1;