Make internals.isPreloaded() to remain the same before/after clearPreloads()

third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
     Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 855 matching lines @@
 void ResourceFetcher::preloadStarted(Resource* resource)
 {
     if (m_preloads && m_preloads->contains(resource))
         return;
     TRACE_EVENT_ASYNC_STEP_INTO0("blink.net", "Resource", resource->identifier(), "Preload");
     resource->increasePreloadCount();
 
     if (!m_preloads)
         m_preloads = new HeapListHashSet<Member<Resource>>;
     m_preloads->add(resource);
+
+    if (m_preloadedURLsForTest)
+        m_preloadedURLsForTest->add(resource->url().getString());
 }
 
-bool ResourceFetcher::isPreloaded(const KURL& url) const
+void ResourceFetcher::enableIsPreloadedForTest()
 {
+    if (m_preloadedURLsForTest)
+        return;
+    m_preloadedURLsForTest = wrapUnique(new HashSet<String>);
+
     if (m_preloads) {
-        for (auto resource : *m_preloads) {
-            if (resource->url() == url)
-                return true;
-        }
+        for (auto resource : *m_preloads)

[Yoav Weiss, 2016/09/15 08:34:31]

nit: const auto&

(I changed all other m_preloads iterations to that in
https://codereview.chromium.org/2343623002/ )

[hiroshige, 2016/09/15 08:39:11]

Done.

+            m_preloadedURLsForTest->add(resource->url().getString());
     }
+}
 
-    return false;
+bool ResourceFetcher::isPreloadedForTest(const KURL& url) const
+{
+    DCHECK(m_preloadedURLsForTest);
+    return m_preloadedURLsForTest->contains(url.getString());
 }
 
 void ResourceFetcher::clearPreloads(ClearPreloadsPolicy policy)
 {
     if (!m_preloads)
         return;
 
     logPreloadStats();
 
     for (auto resource : *m_preloads) {
@@ skipping 426 matching lines @@
     visitor->trace(m_context);
     visitor->trace(m_archive);
     visitor->trace(m_loaders);
     visitor->trace(m_nonBlockingLoaders);
     visitor->trace(m_documentResources);
     visitor->trace(m_preloads);
     visitor->trace(m_resourceTimingInfoMap);
 }
 
 } // namespace blink