Handlify GetProperty.

Handlify GetProperty.

R=ishell@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20682

[Igor Sheludko, 2014-04-11 10:52:12]

lgtm with nits:

https://codereview.chromium.org/233233004/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/233233004/diff/1/src/objects.cc#newcode489
src/objects.cc:489: MaybeHandle<Object> Object::GetProperty(Handle<Object>
object,
Non-handlified version was defined in objects-inl.h, probably it is worth moving
this one there as well.

https://codereview.chromium.org/233233004/diff/1/src/objects.cc#newcode496
src/objects.cc:496: MaybeHandle<Object>
JSProxy::GetElementWithHandler(Handle<JSProxy> proxy,
Simple enough for inlining.

https://codereview.chromium.org/233233004/diff/1/src/objects.cc#newcode877
src/objects.cc:877: value =
Handle<Object>(holder->GetNormalizedProperty(result), isolate);
To be uniform: handle(...)

https://codereview.chromium.org/233233004/diff/1/src/objects.cc#newcode886
src/objects.cc:886: return Handle<Object>(result->GetConstant(), isolate);
Same here.

https://codereview.chromium.org/233233004/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/233233004/diff/1/src/objects.h#newcode1536
src/objects.h:1536: // TODO(yangguo): this should eventually replace the
non-handlified version.
I think this TODO is obsolete now.

[Yang, 2014-04-11 11:21:41]

https://codereview.chromium.org/233233004/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/233233004/diff/1/src/objects.cc#newcode496
src/objects.cc:496: MaybeHandle<Object>
JSProxy::GetElementWithHandler(Handle<JSProxy> proxy,
On 2014/04/11 10:52:13, Igor Sheludko wrote:
> Simple enough for inlining.

Done. Also moved GetPropertyOrElement and GetPropertyWithHandler.

https://codereview.chromium.org/233233004/diff/1/src/objects.cc#newcode877
src/objects.cc:877: value =
Handle<Object>(holder->GetNormalizedProperty(result), isolate);
On 2014/04/11 10:52:13, Igor Sheludko wrote:
> To be uniform: handle(...)

Done.

https://codereview.chromium.org/233233004/diff/1/src/objects.cc#newcode886
src/objects.cc:886: return Handle<Object>(result->GetConstant(), isolate);
On 2014/04/11 10:52:13, Igor Sheludko wrote:
> Same here.

Done.

[Igor Sheludko, 2014-04-11 11:26:27]

lgtm

[Yang, 2014-04-11 11:26:44]

Committed patchset #2 manually as r20682 (presubmit successful).