Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: dart/tests/compiler/dart2js/message_kind_test.dart

Issue 233233002: Copy types object when using a cached compiler. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Found issue during test, added comment. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/compiler/dart2js/memory_compiler.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/compiler/dart2js/message_kind_test.dart
diff --git a/dart/tests/compiler/dart2js/message_kind_test.dart b/dart/tests/compiler/dart2js/message_kind_test.dart
index b2f1e464ed798947416e396620827b2529b788b6..b3cca951ad06ea5f8b0e65e129e605ab61aa0cbf 100644
--- a/dart/tests/compiler/dart2js/message_kind_test.dart
+++ b/dart/tests/compiler/dart2js/message_kind_test.dart
@@ -48,18 +48,10 @@ main() {
asyncTest(() => Future.forEach(examples, (String name) {
print("Checking '$name'.");
Stopwatch sw = new Stopwatch()..start();
- bool useCachedCompiler = true;
- if (name == 'MISSING_LIBRARY_NAME') {
- // TODO(johnniwinther): Found out why we cannot use the cached compiler
- // for this message kind.
- cachedCompiler = null;
- }
- return check(kinds[name], cachedCompiler).
- then((var compiler) {
- cachedCompiler = compiler;
- sw.stop();
- print("Checked '$name' in ${sw.elapsedMilliseconds}ms.");
- });
- }
- ));
+ return check(kinds[name], cachedCompiler).then((var compiler) {
+ cachedCompiler = compiler;
+ sw.stop();
+ print("Checked '$name' in ${sw.elapsedMilliseconds}ms.");
+ });
+ }));
}
« no previous file with comments | « dart/tests/compiler/dart2js/memory_compiler.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698