Copy types object when using a cached compiler.

dart/tests/compiler/dart2js/memory_compiler.dart

Index: dart/tests/compiler/dart2js/memory_compiler.dart
diff --git a/dart/tests/compiler/dart2js/memory_compiler.dart b/dart/tests/compiler/dart2js/memory_compiler.dart
index 392f51b6bf3a36251bc7e48f634c42bc6fd82ef4..57e65bfa57677a87a17f8b8850bf48b6c9c34f29 100644
--- a/dart/tests/compiler/dart2js/memory_compiler.dart
+++ b/dart/tests/compiler/dart2js/memory_compiler.dart
@@ -165,7 +165,7 @@ Compiler compilerFor(Map<String,String> memorySourceFiles,
                                    {});
   if (cachedCompiler != null) {
     compiler.coreLibrary = cachedCompiler.libraries['dart:core'];
-    compiler.types = cachedCompiler.types;
+    compiler.types = cachedCompiler.types.copy(compiler);
     cachedCompiler.libraries.forEach((String uri, library) {
       if (library.isPlatformLibrary) {
         compiler.libraries[uri] = library;
@@ -193,6 +193,24 @@ Compiler compilerFor(Map<String,String> memorySourceFiles,
             treeElements;
       }
     });
+
+    cachedCompiler.scanner = null;

[Johnni Winther, 2014/04/10 13:51:55]

Add a comment about why these resets are needed.

[ahe, 2014/04/10 14:02:48]

I'll add a comment.

The resets aren't needed, and mostly helpful for debugging future problems like
this. Would you prefer I remove this code?

[Johnni Winther, 2014/04/10 14:08:47]

Keep it in - with a comment.

+    cachedCompiler.dietParser = null;
+    cachedCompiler.parser = null;
+    cachedCompiler.patchParser = null;
+    cachedCompiler.libraryLoader = null;
+    cachedCompiler.validator = null;
+    cachedCompiler.resolver = null;
+    cachedCompiler.closureToClassMapper = null;
+    cachedCompiler.checker = null;
+    cachedCompiler.irBuilder = null;
+    cachedCompiler.typesTask = null;
+    cachedCompiler.backend = null;
+    cachedCompiler.enqueuer = null;
+    cachedCompiler.deferredLoadTask = null;
+    cachedCompiler.mirrorUsageAnalyzerTask = null;
+    cachedCompiler.dumpInfoTask = null;
+    cachedCompiler.buildId = null;
   }
   return compiler;
 }