Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: third_party/WebKit/Source/modules/sensor/SensorReading.h

Issue 2332323002: [sensors] Ambient light sensor bindings implementation (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/SensorReading.h
diff --git a/third_party/WebKit/Source/modules/sensor/SensorReading.h b/third_party/WebKit/Source/modules/sensor/SensorReading.h
index 2eaf7e6a177db48e75962b885ee31ae8b643de3d..ee5f3efe0e7723657aa6770fc2db44f1d998c0f3 100644
--- a/third_party/WebKit/Source/modules/sensor/SensorReading.h
+++ b/third_party/WebKit/Source/modules/sensor/SensorReading.h
@@ -16,7 +16,7 @@ class ExecutionContext;
class ScriptState;
class SensorReading
- : public GarbageCollected<SensorReading>
+ : public GarbageCollectedFinalized<SensorReading>
, public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
@@ -26,7 +26,10 @@ public:
// Returns 'true' if the current reading value is different than the given
// previous one; otherwise returns 'false'.
- virtual bool isReadingUpdated(const SensorProxy::Reading& previous) const = 0;
+ virtual bool isReadingUpdated(const SensorProxy::Reading& previous) const;
+
+ // Required by GarbageCollectedFinalized.
haraken 2016/09/13 09:45:04 You can use GarbageCollected.
shalamov 2016/09/13 10:34:17 I made SensorReading GarbageCollectedMixin and der
+ virtual ~SensorReading();
protected:
explicit SensorReading(SensorProxy*);

Powered by Google App Engine
This is Rietveld 408576698