Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2332293003: Start enabling platform_canvas_unittests on Linux (Closed)

Created:
4 years, 3 months ago by tomhudson
Modified:
4 years, 3 months ago
Reviewers:
f(malita)
CC:
chromium-reviews, reed2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start enabling platform_canvas_unittests on Linux These unittests have been disabled for years, limiting our coverage; by implementing a Cairo version of DrawNativeRect() we can turn on at least a few of them. R=fmalita@chromium.org BUG=154358 Committed: https://crrev.com/8eae448d476210d6b89077ef27f8a0ee9dfcbef0 Cr-Commit-Position: refs/heads/master@{#418545}

Patch Set 1 #

Patch Set 2 : make gn consistent, turn on clipping test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M skia/BUILD.gn View 1 2 chunks +7 lines, -1 line 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 1 5 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tomhudson
PTAL
4 years, 3 months ago (2016-09-14 12:33:26 UTC) #7
f(malita)
lgtm
4 years, 3 months ago (2016-09-14 13:39:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332293003/20001
4 years, 3 months ago (2016-09-14 13:43:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 13:47:39 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 13:49:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8eae448d476210d6b89077ef27f8a0ee9dfcbef0
Cr-Commit-Position: refs/heads/master@{#418545}

Powered by Google App Engine
This is Rietveld 408576698