Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2332293002: Revert of Use modifed URLRequest API in net/cert_net (Closed)

Created:
4 years, 3 months ago by maksims (do not use this acc)
Modified:
4 years, 3 months ago
Reviewers:
fs, mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use modifed URLRequest API in net/cert_net (patchset #1 id:1 of https://codereview.chromium.org/2330873002/ ) Reason for revert: This part of the big CL makes net unittests run on android bot to be flaky. Original issue's description: > Use modifed URLRequest API in net/cert_net > > This cl splits the big CL with changes to net/ folder and > has changes only to net/cert_net according to the > changes to URLRequest API. > > What the big cl does: > It modifies net/ clients that use URLRequest API as long as > URLRequest::Read returns int net errors and > URLRequest::Delegate and NetworkDelegate methods > (for example, OnResponseStarted or OnCompleted) have int > net_error in the arguments now. > > The reason behind splitting the CL into small one is that > an android bot started to be unstable and unittests became > flaky. It was not possible to locate the problem and the > decision was to split the CL and upload small parts with a > 6+ hours interval in order to make it possible to locate > the problematic code. > > The big CL is located here - > https://codereview.chromium.org/2265873002/ > > BUG=423484 > > Committed: https://crrev.com/a74d3cbc572fa1c85cc2c0434a9f8e2f9cba0cd9 > Cr-Commit-Position: refs/heads/master@{#418014} TBR=mmenke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=423484 Committed: https://crrev.com/141929f4732e4beb9c16a5c9b54f55a95e644e6c Cr-Commit-Position: refs/heads/master@{#418191}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -51 lines) Patch
M net/cert_net/cert_net_fetcher_impl.cc View 12 chunks +48 lines, -42 lines 0 comments Download
M net/cert_net/nss_ocsp.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
maksims (do not use this acc)
Created Revert of Use modifed URLRequest API in net/cert_net
4 years, 3 months ago (2016-09-13 07:15:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332293002/1
4 years, 3 months ago (2016-09-13 07:15:30 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-13 07:15:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332293002/1
4 years, 3 months ago (2016-09-13 07:15:52 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-13 07:15:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332293002/1
4 years, 3 months ago (2016-09-13 07:45:50 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-13 07:45:52 UTC) #13
fs
lgtm
4 years, 3 months ago (2016-09-13 07:46:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332293002/1
4 years, 3 months ago (2016-09-13 07:47:00 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 07:47:47 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 07:50:23 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/141929f4732e4beb9c16a5c9b54f55a95e644e6c
Cr-Commit-Position: refs/heads/master@{#418191}

Powered by Google App Engine
This is Rietveld 408576698