content/browser/loader/resource_dispatcher_host_impl.cc - Issue 2332263002: Updated suborigin serialization to latest spec proposal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 2332263002: Updated suborigin serialization to latest spec proposal (Closed)

Patch Set: Convert suborigin schemes to pseudo schemes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index 21183c34ab6026001aeeccdfca30332555a1e1f1..b0794f53a130f3897295a44b532c10fd25b6f8e2 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -2681,7 +2681,7 @@ bool ResourceDispatcherHostImpl::ShouldServiceRequest(

headers.GetHeader("Origin", &origin_string) && origin_string != "null";

if (has_origin) {

GURL origin(origin_string);

- if (!policy->CanCommitURL(child_id, origin)) {

+ if (!policy->CanSetAsOriginHeader(child_id, origin)) {

VLOG(1) << "Killed renderer for illegal origin: " << origin_string;

bad_message::ReceivedBadMessage(filter, bad_message::RDH_ILLEGAL_ORIGIN);

return false;