third_party/WebKit/Source/platform/weborigin/KURLTest.cpp - Issue 2332263002: Updated suborigin serialization to latest spec proposal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/weborigin/KURLTest.cpp

Issue 2332263002: Updated suborigin serialization to latest spec proposal (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/child_process_security_policy_unittest.cc ('K') | « third_party/WebKit/Source/platform/weborigin/KURL.cpp ('k') | third_party/WebKit/Source/platform/weborigin/SecurityOrigin.h » ('j') | url/url_constants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/weborigin/KURLTest.cpp

diff --git a/third_party/WebKit/Source/platform/weborigin/KURLTest.cpp b/third_party/WebKit/Source/platform/weborigin/KURLTest.cpp

index b3c0a2a4b50b0bba49197911801c4624ffd6189e..08ee7dfa7d833a70032f51685052ae50dfaac7f6 100644

--- a/third_party/WebKit/Source/platform/weborigin/KURLTest.cpp

+++ b/third_party/WebKit/Source/platform/weborigin/KURLTest.cpp

@@ -428,10 +428,18 @@ TEST(KURLTest, Valid_HTTP_FTP_URLsHaveHosts)

EXPECT_TRUE(kurl.protocolIs("http"));

EXPECT_FALSE(kurl.isValid());

+ EXPECT_TRUE(kurl.setProtocol("http-so"));

+ EXPECT_TRUE(kurl.protocolIs("http-so"));

+ EXPECT_FALSE(kurl.isValid());

EXPECT_TRUE(kurl.setProtocol("https"));

EXPECT_TRUE(kurl.protocolIs("https"));

EXPECT_FALSE(kurl.isValid());

+ EXPECT_TRUE(kurl.setProtocol("https-so"));

+ EXPECT_TRUE(kurl.protocolIs("https-so"));

+ EXPECT_FALSE(kurl.isValid());

EXPECT_TRUE(kurl.setProtocol("ftp"));

EXPECT_TRUE(kurl.protocolIs("ftp"));

EXPECT_FALSE(kurl.isValid());

@@ -440,10 +448,18 @@ TEST(KURLTest, Valid_HTTP_FTP_URLsHaveHosts)

EXPECT_TRUE(kurl.protocolIs("http"));

EXPECT_FALSE(kurl.isValid());

+ kurl = KURL(KURL(), "http-so://");

+ EXPECT_TRUE(kurl.protocolIs("http-so"));

+ EXPECT_FALSE(kurl.isValid());

kurl = KURL(KURL(), "https://");

EXPECT_TRUE(kurl.protocolIs("https"));

EXPECT_FALSE(kurl.isValid());

+ kurl = KURL(KURL(), "https-so://");

+ EXPECT_TRUE(kurl.protocolIs("https-so"));

+ EXPECT_FALSE(kurl.isValid());

kurl = KURL(KURL(), "ftp://");

EXPECT_TRUE(kurl.protocolIs("ftp"));

EXPECT_FALSE(kurl.isValid());

@@ -453,11 +469,21 @@ TEST(KURLTest, Valid_HTTP_FTP_URLsHaveHosts)

kurl.setHost("");

EXPECT_FALSE(kurl.isValid());

+ kurl = KURL(KURL(), "http-so://host/");

+ EXPECT_TRUE(kurl.isValid());

+ kurl.setHost("");

+ EXPECT_FALSE(kurl.isValid());

kurl = KURL(KURL(), "https://host/");

EXPECT_TRUE(kurl.isValid());

kurl.setHost("");

EXPECT_FALSE(kurl.isValid());

+ kurl = KURL(KURL(), "https-so://host/");

+ EXPECT_TRUE(kurl.isValid());

+ kurl.setHost("");

+ EXPECT_FALSE(kurl.isValid());

kurl = KURL(KURL(), "ftp://host/");

EXPECT_TRUE(kurl.isValid());

kurl.setHost("");