Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc

Issue 2332253002: Print more info when DomDistillerJsTest fails (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc
diff --git a/components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc b/components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc
index 9ced84019dcad41e4e544aecd10b34a959b7c344..2fcab0ee2490c49f55309be6fb24b1d8c795c6e4 100644
--- a/components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc
+++ b/components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc
@@ -50,7 +50,7 @@ namespace dom_distiller {
const char* kExternalTestResourcesPath =
"third_party/dom_distiller_js/dist/test/data";
-const char* kTestFilePath = "/war/test.html?console_log=0";
+const char* kTestFilePath = "/war/test.html?console_log=0&filter=*.*";
const char* kRunJsTestsJs =
"(function() {return org.chromium.distiller.JsTestEntry.run();})();";
@@ -162,6 +162,10 @@ IN_PROC_BROWSER_TEST_F(DomDistillerJsTest, RunJsTests) {
std::string console_log;
ASSERT_TRUE(dict->GetString("log", &console_log));
VLOG(0) << "Console log:\n" << console_log;
+ VLOG(0) << "\n\n"
+ "More info at third_party/dom_distiller_js/README.chromium.\n"
+ "To disable tests, modify the filter parameter in |kTestFilePath|,\n"
+ "in gtest_filter syntax.\n\n";
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698