Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2332253002: Print more info when DomDistillerJsTest fails (Closed)

Created:
4 years, 3 months ago by wychen
Modified:
4 years, 2 months ago
Reviewers:
mdjones
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Print more info when DomDistillerJsTest fails Committed: https://crrev.com/231b8007135adb62affaa297bafa15bff479c0f5 Cr-Commit-Position: refs/heads/master@{#422566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M components/dom_distiller/content/browser/test/dom_distiller_js_browsertest.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
wychen
PTAL
4 years, 2 months ago (2016-10-03 06:20:38 UTC) #2
mdjones
lgtm
4 years, 2 months ago (2016-10-03 16:01:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332253002/1
4 years, 2 months ago (2016-10-03 21:49:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 22:28:01 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 22:30:38 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/231b8007135adb62affaa297bafa15bff479c0f5
Cr-Commit-Position: refs/heads/master@{#422566}

Powered by Google App Engine
This is Rietveld 408576698