Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2332213008: Revert of Revert "[Clock sync] Use clock sync manager to convert trace event timestamps" (Closed)

Created:
4 years, 3 months ago by nednguyen
Modified:
4 years, 3 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org, nednguyen
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Revert "[Clock sync] Use clock sync manager to convert trace event timestamps" (patchset #1 id:1 of https://codereview.chromium.org/2345463003/ ) Reason for revert: Revert this will break trace view on Android as https://codereview.chromium.org/2301523007/ has landed. Original issue's description: > Revert "[Clock sync] Use clock sync manager to convert trace event timestamps" > > This reverts commit 260117fe0d2e76f878268a4c84e23ba0332e1329. > > TBR=oystein@chromium.org > BUG=catapult:#646925 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bb1d0fa5322f968b9db12cda686c17d4670fd2ee TBR=oysteine@chromium.org,charliea@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#646925 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4818ce067d09aa659627536bb30f084b5640013e

Patch Set 1 #

Patch Set 2 : Enable blink.console #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -52 lines) Patch
M telemetry/telemetry/web_perf/timeline_based_measurement.py View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tracing/tracing/extras/importer/trace_event_importer.html View 1 33 chunks +134 lines, -50 lines 0 comments Download
M tracing/tracing/extras/importer/trace_event_importer_test.html View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
nednguyen
Created Revert of Revert "[Clock sync] Use clock sync manager to convert trace event timestamps"
4 years, 3 months ago (2016-09-14 21:52:47 UTC) #1
nednguyen
+Oysteine, Zhen: please review the change to telemetry/telemetry/web_perf/timeline_based_measurement.py & click CQ if you think this ...
4 years, 3 months ago (2016-09-14 22:29:23 UTC) #3
oystein (OOO til 10th of July)
lgtm lgtm
4 years, 3 months ago (2016-09-14 22:30:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332213008/70001
4 years, 3 months ago (2016-09-14 22:30:59 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 22:31:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698