Bundle common arguments to GrGradientEffect creation

Bundle common arguments to GrGradientEffect creation

I'm going to be adding more (to deal with color spaces), so trying to fix
this before it gets out of control.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007

Committed: https://skia.googlesource.com/skia/+/f605c16a030d791a37f589e6bddd7158ba5d62cd
Committed: https://skia.googlesource.com/skia/+/9557c273d8b10ad057b7932875828de204a5d00e

[Brian Osman, 2016-09-14 15:54:41]

Description was changed from

==========
Bundle common arguments to GrGradientEffect creation

I'm going to be adding more (to deal with color spaces), so trying to fix
this before it gets out of control.

BUG=skia:
==========

to

==========
Bundle common arguments to GrGradientEffect creation

I'm going to be adding more (to deal with color spaces), so trying to fix
this before it gets out of control.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007
==========

[Brian Osman, 2016-09-14 15:56:33]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 15:56:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-09-14 15:56:56]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[bsalomon, 2016-09-14 16:15:13]

lgtm

https://codereview.chromium.org/2332213007/diff/1/src/effects/gradients/SkGra...
File src/effects/gradients/SkGradientShader.cpp (right):

https://codereview.chromium.org/2332213007/diff/1/src/effects/gradients/SkGra...
src/effects/gradients/SkGradientShader.cpp:1335:
GrGradientEffect::GrGradientEffect(const GrGradientEffect::CreateArgs& args) {
Can just say CreateArgs for the param type.

[commit-bot: I haz the power, 2016-09-14 16:26:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 16:26:13]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-09-14 16:40:07]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-09-14 16:40:08]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2332213007/#ps20001
(title: "Remove unncessary scoping")

[commit-bot: I haz the power, 2016-09-14 16:40:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 17:03:48]

Description was changed from

==========
Bundle common arguments to GrGradientEffect creation

I'm going to be adding more (to deal with color spaces), so trying to fix
this before it gets out of control.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007
==========

to

==========
Bundle common arguments to GrGradientEffect creation

I'm going to be adding more (to deal with color spaces), so trying to fix
this before it gets out of control.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007

Committed:
https://skia.googlesource.com/skia/+/f605c16a030d791a37f589e6bddd7158ba5d62cd
==========

[commit-bot: I haz the power, 2016-09-14 17:03:49]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f605c16a030d791a37f589e6bddd7158ba5d62cd

[djsollen, 2016-09-15 02:57:47]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2343703003/ by djsollen@google.com.

The reason for reverting is: This seems to be causing the autoroll into Chromium
to fail.

https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu....

[Brian Osman, 2016-09-15 13:27:31]

Description was changed from

==========
Bundle common arguments to GrGradientEffect creation

I'm going to be adding more (to deal with color spaces), so trying to fix
this before it gets out of control.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007

Committed:
https://skia.googlesource.com/skia/+/f605c16a030d791a37f589e6bddd7158ba5d62cd
==========

to

==========
Bundle common arguments to GrGradientEffect creation

I'm going to be adding more (to deal with color spaces), so trying to fix
this before it gets out of control.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007

Committed:
https://skia.googlesource.com/skia/+/f605c16a030d791a37f589e6bddd7158ba5d62cd
==========

[Brian Osman, 2016-09-15 13:28:56]

brianosman@google.com changed reviewers:
+ djsollen@google.com

[Brian Osman, 2016-09-15 13:28:57]

Fixed. (Verified locally with a non-GPU build). Checked with Eric, turns out
that our non-GPU bots weren't actually compiling with skia_gpu=0.

[Brian Osman, 2016-09-15 13:29:05]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-09-15 13:29:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2332213007/#ps40001
(title: "Fix non-GPU compile errors")

[commit-bot: I haz the power, 2016-09-15 13:29:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 13:59:17]

Description was changed from

==========
Bundle common arguments to GrGradientEffect creation

I'm going to be adding more (to deal with color spaces), so trying to fix
this before it gets out of control.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007

Committed:
https://skia.googlesource.com/skia/+/f605c16a030d791a37f589e6bddd7158ba5d62cd
==========

to

==========
Bundle common arguments to GrGradientEffect creation

I'm going to be adding more (to deal with color spaces), so trying to fix
this before it gets out of control.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2332213007

Committed:
https://skia.googlesource.com/skia/+/f605c16a030d791a37f589e6bddd7158ba5d62cd
Committed:
https://skia.googlesource.com/skia/+/9557c273d8b10ad057b7932875828de204a5d00e
==========

[commit-bot: I haz the power, 2016-09-15 13:59:18]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9557c273d8b10ad057b7932875828de204a5d00e