Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2332213005: Media Recorder browser tests: remove MediaRecorder prefix from individual browser tests (Closed)

Created:
4 years, 3 months ago by mcasas
Modified:
4 years, 3 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Recorder browser tests: remove MediaRecorder prefix from individual browser tests No bug, just a naming cleanup: since the Unit test is called WebRtcMediaRecorderTest, it's completely redundant to prefix the individual tests MediaRecorderFoo, so this CL removed the "MediaRecorder" test case prefix. Committed: https://crrev.com/f77b9c923d5269d638785e17b652822ca0a1f33c Cr-Commit-Position: refs/heads/master@{#418551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -24 lines) Patch
M content/browser/webrtc/webrtc_media_recorder_browsertest.cc View 1 chunk +17 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mcasas
phoglund@ PTAL
4 years, 3 months ago (2016-09-13 23:00:31 UTC) #2
phoglund_chromium
lgtm
4 years, 3 months ago (2016-09-14 09:07:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332213005/1
4 years, 3 months ago (2016-09-14 13:29:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-14 14:10:02 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 14:11:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f77b9c923d5269d638785e17b652822ca0a1f33c
Cr-Commit-Position: refs/heads/master@{#418551}

Powered by Google App Engine
This is Rietveld 408576698