Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2332213003: Add ensure_goma to NaCl SDK recipies (Closed)

Created:
4 years, 3 months ago by Sam Clegg
Modified:
4 years, 3 months ago
Reviewers:
bradnelson, binji
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add ensure_goma to NaCl SDK recipies The are all currently failing during the compile phase because they can't start goma. BUG=646185 Committed: https://chromium.googlesource.com/chromium/tools/build/+/99ab4dbc8b5e801493dca8cf3b5535014baec965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -12 lines) Patch
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.py View 6 chunks +12 lines, -0 lines 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_asan_multi.json View 2 chunks +59 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multi.json View 2 chunks +59 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/linux_sdk_multirel.json View 2 chunks +59 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multi.json View 2 chunks +59 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/mac_sdk_multirel.json View 2 chunks +59 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multi.json View 2 chunks +59 lines, -1 line 0 comments Download
M scripts/slave/recipes/client.nacl.sdk.recipe_autogen.expected/windows_sdk_multirel.json View 2 chunks +59 lines, -1 line 0 comments Download
M scripts/slave/recipes/nacl/sdk.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/nacl/sdk.expected/basic.json View 4 chunks +61 lines, -3 lines 0 comments Download
M scripts/slave/recipes/nacl/sdk_build.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/nacl/sdk_build.expected/basic.json View 3 chunks +60 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Sam Clegg
4 years, 3 months ago (2016-09-13 20:39:47 UTC) #4
bradnelson
lgtm
4 years, 3 months ago (2016-09-13 20:42:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332213003/1
4 years, 3 months ago (2016-09-13 20:44:23 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 20:49:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/99ab4dbc8b5e801493dc...

Powered by Google App Engine
This is Rietveld 408576698