Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2332213002: [Download Home] Properly enqueue download requests (Closed)

Created:
4 years, 3 months ago by gone
Modified:
4 years, 3 months ago
Reviewers:
qinmin, Min Qin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Download Home] Properly enqueue download requests Trying to shoehorn pending actions into the PendingDownloadActions queue doesn't work unless you use a unique download ID. Just store a separate int that tracks what downloads have been requested. BUG=645926 Committed: https://crrev.com/3f63c614e8c4501b1bfa3f608e32a9d12618b0a0 Cr-Commit-Position: refs/heads/master@{#418117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M chrome/browser/android/download/download_manager_service.h View 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/browser/android/download/download_manager_service.cc View 5 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
gone
Going to cherry-pick this back to M54; will add a test afterward to keep this ...
4 years, 3 months ago (2016-09-12 23:22:20 UTC) #2
qinmin
lgtm
4 years, 3 months ago (2016-09-13 00:04:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332213002/1
4 years, 3 months ago (2016-09-13 00:14:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 00:21:25 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 00:25:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f63c614e8c4501b1bfa3f608e32a9d12618b0a0
Cr-Commit-Position: refs/heads/master@{#418117}

Powered by Google App Engine
This is Rietveld 408576698