JobController3: Move MarkAlternativeServiceBroken to job controller

net/http/http_stream_factory_impl_job_controller.h

Index: net/http/http_stream_factory_impl_job_controller.h
diff --git a/net/http/http_stream_factory_impl_job_controller.h b/net/http/http_stream_factory_impl_job_controller.h
index d54165028ab569ff72e50a2710da9e0e8703d539..fe5d0b027bf0a984972d09ddf8b7935c759e8fd9 100644
--- a/net/http/http_stream_factory_impl_job_controller.h
+++ b/net/http/http_stream_factory_impl_job_controller.h
@@ -201,6 +201,13 @@ class HttpStreamFactoryImpl::JobController
                            NextProto negotiated_protocol,
                            bool using_spdy);
 
+  // Must be called when |alternative_job_| fails.
+  void MarkAlternativeServiceBroken(Job* job);
+
+  // Called to report to http_server_properties to mark alternative service
+  // broken.
+  void ReportAlternativeServiceBroken(Job* job);

[Ryan Hamilton, 2016/09/14 21:45:42]

nit: How about "ReportBrokenAlternativeService", which reads ever so slightly
more like a sentence.

[Zhongyi Shi, 2016/09/14 23:07:07]

Done.

+
   void MaybeNotifyFactoryOfCompletion();
 
   // Called to resume the main job with delay.
@@ -255,6 +262,15 @@ class HttpStreamFactoryImpl::JobController
   std::unique_ptr<Job> main_job_;
   std::unique_ptr<Job> alternative_job_;
 
+  // True if |alternative_job_| uses alternative service/proxy server and
+  // discovers it as broken.
+  bool alternative_service_is_broken_;

[Ryan Hamilton, 2016/09/14 21:45:42]

Instead of "broken", let's use "failed" here. Broken is only the state we reach
when alt-svc fails and main succeeds. (and in the members below)

That would also suggest renaming MarkAlternativeServiceBroken to
MarkAlternativeServiceJobFailed. (Or perhaps OnAlternativeServiceJobFailed).

[Zhongyi Shi, 2016/09/14 23:07:07]

Done.

+
+  // Either and only one of these records broken alternative service/proxy
+  // server that |alternative_job_| uses.
+  AlternativeService broken_alternative_service_;
+  ProxyServer broken_alternative_proxy_server_;
+
   // True if a Job has ever been bound to the |request_|.
   bool job_bound_;