Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: net/http/http_stream_factory_impl_job_controller_unittest.cc

Issue 2332193003: JobController3: Move MarkAlternativeServiceBroken to job controller (Closed)
Patch Set: some nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_job_controller_unittest.cc
diff --git a/net/http/http_stream_factory_impl_job_controller_unittest.cc b/net/http/http_stream_factory_impl_job_controller_unittest.cc
index 63d22fb4373b9f15ba45e25ee7c24636a9417414..2e6176c66dff074274e799f16595053446228f97 100644
--- a/net/http/http_stream_factory_impl_job_controller_unittest.cc
+++ b/net/http/http_stream_factory_impl_job_controller_unittest.cc
@@ -295,7 +295,6 @@ TEST_F(HttpStreamFactoryImplJobControllerTest, OnStreamFailedForBothJobs) {
// thus should not notify Request of the alternative job's failure. But should
// notify the main job to mark the alternative job failed.
EXPECT_CALL(request_delegate_, OnStreamFailed(_, _)).Times(0);
- EXPECT_CALL(*job_factory_.main_job(), MarkOtherJobComplete(_)).Times(1);
job_controller_->OnStreamFailed(job_factory_.alternative_job(), ERR_FAILED,
SSLConfig());
EXPECT_TRUE(!job_controller_->alternative_job());
@@ -344,8 +343,6 @@ TEST_F(HttpStreamFactoryImplJobControllerTest,
EXPECT_CALL(request_delegate_, OnStreamReady(_, _, http_stream))
.WillOnce(Invoke(DeleteHttpStreamPointer));
- EXPECT_CALL(*job_factory_.alternative_job(), MarkOtherJobComplete(_))
- .Times(1);
job_controller_->OnStreamReady(job_factory_.main_job(), SSLConfig(),
ProxyInfo());
@@ -390,8 +387,6 @@ TEST_F(HttpStreamFactoryImplJobControllerTest,
// |main_job| fails but should not report status to Request.
// The alternative job will mark the main job complete.
EXPECT_CALL(request_delegate_, OnStreamFailed(_, _)).Times(0);
- EXPECT_CALL(*job_factory_.alternative_job(), MarkOtherJobComplete(_))
- .Times(1);
job_controller_->OnStreamFailed(job_factory_.main_job(), ERR_FAILED,
SSLConfig());
@@ -438,8 +433,6 @@ TEST_F(HttpStreamFactoryImplJobControllerTest, GetLoadStateAfterMainJobFailed) {
// |main_job| fails but should not report status to Request.
// The alternative job will mark the main job complete.
EXPECT_CALL(request_delegate_, OnStreamFailed(_, _)).Times(0);
- EXPECT_CALL(*job_factory_.alternative_job(), MarkOtherJobComplete(_))
- .Times(1);
job_controller_->OnStreamFailed(job_factory_.main_job(), ERR_FAILED,
SSLConfig());
@@ -488,7 +481,6 @@ TEST_F(HttpStreamFactoryImplJobControllerTest, DoNotResumeMainJobBeforeWait) {
// Wait until OnStreamFailedCallback is executed on the alternative job.
EXPECT_CALL(request_delegate_, OnStreamFailed(_, _)).Times(1);
- EXPECT_CALL(*job_factory_.main_job(), MarkOtherJobComplete(_)).Times(1);
base::RunLoop().RunUntilIdle();
}
@@ -514,7 +506,6 @@ TEST_F(HttpStreamFactoryImplJobControllerTest, InvalidPortForQuic) {
// Wait until OnStreamFailedCallback is executed on the alternative job.
EXPECT_CALL(*job_factory_.main_job(), Resume()).Times(1);
- EXPECT_CALL(*job_factory_.main_job(), MarkOtherJobComplete(_)).Times(1);
base::RunLoop().RunUntilIdle();
}
@@ -580,7 +571,6 @@ TEST_F(HttpStreamFactoryImplJobControllerTest,
resolver.pending_requests()[0]->CompleteNow(net::OK);
EXPECT_CALL(request_delegate_, OnStreamFailed(_, _)).Times(0);
EXPECT_CALL(*job_factory_.main_job(), Resume()).Times(1);
- EXPECT_CALL(*job_factory_.main_job(), MarkOtherJobComplete(_)).Times(1);
base::RunLoop().RunUntilIdle();
}
@@ -645,7 +635,6 @@ TEST_F(HttpStreamFactoryImplJobControllerTest,
// Request shouldn't be notified as the main job is still pending status.
EXPECT_CALL(request_delegate_, OnStreamFailed(_, _)).Times(0);
EXPECT_CALL(*job_factory_.main_job(), Resume()).Times(1);
- EXPECT_CALL(*job_factory_.main_job(), MarkOtherJobComplete(_)).Times(1);
base::RunLoop().RunUntilIdle();
}
@@ -839,7 +828,6 @@ TEST_F(HttpStreamFactoryImplJobControllerTest, FailAlternativeProxy) {
EXPECT_TRUE(job_controller_->alternative_job());
EXPECT_CALL(request_delegate_, OnStreamReady(_, _, _)).Times(0);
- EXPECT_CALL(*job_factory_.main_job(), MarkOtherJobComplete(_)).Times(1);
// Since the alternative proxy server job is started in the next message loop,
// the main job would remain blocked until the alternative proxy starts, and

Powered by Google App Engine
This is Rietveld 408576698