Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: src/inspector/V8StackTraceImpl.cpp

Issue 2332163002: [inspector] fixed all shorten-64-to-32 warnings (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/V8StackTraceImpl.cpp
diff --git a/src/inspector/V8StackTraceImpl.cpp b/src/inspector/V8StackTraceImpl.cpp
index 25a0e7caf7892fd68b21cc0a37fa66cd5eee186f..093d0ef6d317375cab561805379b11f95e2f39ce 100644
--- a/src/inspector/V8StackTraceImpl.cpp
+++ b/src/inspector/V8StackTraceImpl.cpp
@@ -45,7 +45,8 @@ void toFramesVector(v8::Local<v8::StackTrace> stackTrace,
size_t maxStackSize, v8::Isolate* isolate) {
DCHECK(isolate->InContext());
int frameCount = stackTrace->GetFrameCount();
- if (frameCount > static_cast<int>(maxStackSize)) frameCount = maxStackSize;
+ if (frameCount > static_cast<int>(maxStackSize))
+ frameCount = static_cast<int>(maxStackSize);
for (int i = 0; i < frameCount; i++) {
v8::Local<v8::StackFrame> stackFrame = stackTrace->GetFrame(i);
frames.push_back(toFrame(stackFrame));
@@ -159,8 +160,9 @@ std::unique_ptr<V8StackTraceImpl> V8StackTraceImpl::capture(
v8::Local<v8::StackTrace> stackTrace;
if (isolate->InContext()) {
isolate->GetCpuProfiler()->CollectSample();
- stackTrace = v8::StackTrace::CurrentStackTrace(isolate, maxStackSize,
- stackTraceOptions);
+ DCHECK(maxStackSize <= std::numeric_limits<int>::max());
+ stackTrace = v8::StackTrace::CurrentStackTrace(
+ isolate, static_cast<int>(maxStackSize), stackTraceOptions);
}
return V8StackTraceImpl::create(debugger, contextGroupId, stackTrace,
maxStackSize, description);

Powered by Google App Engine
This is Rietveld 408576698