Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: src/inspector/V8Debugger.cpp

Issue 2332163002: [inspector] fixed all shorten-64-to-32 warnings (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/V8Debugger.cpp
diff --git a/src/inspector/V8Debugger.cpp b/src/inspector/V8Debugger.cpp
index 1d4217cf93957e34acd582a4298b41dba6ea2e11..0f4bc610fc5dd15fd3b42d980b62616ad5f28cc9 100644
--- a/src/inspector/V8Debugger.cpp
+++ b/src/inspector/V8Debugger.cpp
@@ -378,9 +378,13 @@ bool V8Debugger::setScriptSource(
.setExceptionId(m_inspector->nextExceptionId())
.setText(toProtocolStringWithTypeCheck(resultTuple->Get(2)))
.setLineNumber(
- resultTuple->Get(3)->ToInteger(m_isolate)->Value() - 1)
+ static_cast<int>(
+ resultTuple->Get(3)->ToInteger(m_isolate)->Value()) -
+ 1)
.setColumnNumber(
- resultTuple->Get(4)->ToInteger(m_isolate)->Value() - 1)
+ static_cast<int>(
+ resultTuple->Get(4)->ToInteger(m_isolate)->Value()) -
+ 1)
.build();
return false;
}
@@ -412,7 +416,7 @@ JavaScriptCallFrames V8Debugger::currentCallFrames(int limit) {
if (!currentCallFramesV8->IsArray()) return JavaScriptCallFrames();
v8::Local<v8::Array> callFramesArray = currentCallFramesV8.As<v8::Array>();
JavaScriptCallFrames callFrames;
- for (size_t i = 0; i < callFramesArray->Length(); ++i) {
+ for (uint32_t i = 0; i < callFramesArray->Length(); ++i) {
v8::Local<v8::Value> callFrameValue;
if (!callFramesArray->Get(debuggerContext(), i).ToLocal(&callFrameValue))
return JavaScriptCallFrames();
@@ -458,7 +462,7 @@ void V8Debugger::handleProgramBreak(v8::Local<v8::Context> pausedContext,
std::vector<String16> breakpointIds;
if (!hitBreakpointNumbers.IsEmpty()) {
breakpointIds.reserve(hitBreakpointNumbers->Length());
- for (size_t i = 0; i < hitBreakpointNumbers->Length(); i++) {
+ for (uint32_t i = 0; i < hitBreakpointNumbers->Length(); i++) {
v8::Local<v8::Value> hitBreakpointNumber = hitBreakpointNumbers->Get(i);
DCHECK(!hitBreakpointNumber.IsEmpty() && hitBreakpointNumber->IsInt32());
breakpointIds.push_back(
@@ -579,9 +583,9 @@ void V8Debugger::handleV8AsyncTaskEvent(v8::Local<v8::Context> context,
callInternalGetterFunction(eventData, "type"));
String16 name = toProtocolStringWithTypeCheck(
callInternalGetterFunction(eventData, "name"));
- int id = callInternalGetterFunction(eventData, "id")
- ->ToInteger(m_isolate)
- ->Value();
+ int id = static_cast<int>(callInternalGetterFunction(eventData, "id")
+ ->ToInteger(m_isolate)
+ ->Value());
// The scopes for the ids are defined by the eventData.name namespaces. There
// are currently two namespaces: "Object." and "Promise.".
void* ptr = reinterpret_cast<void*>(id * 4 + (name[0] == 'P' ? 2 : 0) + 1);

Powered by Google App Engine
This is Rietveld 408576698