Call session_manager's EmitArcBooted() D-Bus method when ARC is ready

Call session_manager's EmitArcBooted() D-Bus method when ARC is ready

This depends on https://chromium-review.googlesource.com/#/c/384594/

BUG=b:31254747
TEST=manually confirmed that the method is actually called

Committed: https://crrev.com/2171e4b359a0037b7f21f81d381d7d301e79aa9e
Cr-Commit-Position: refs/heads/master@{#418721}

[Yusuke Sato, 2016-09-12 22:18:19]

yusukes@chromium.org changed reviewers:
+ derat@chromium.org, lhchavez@chromium.org

[Yusuke Sato, 2016-09-12 22:18:20]

OWNERs, please take a look.

Dan: chromeos/ and c/b/chromeos/
Luis: components/arc/

I'll run trybots once I roll third_party/cros_system_api/.

To Luis: this is for removing the Upstart hack (arc-boot-watcher.conf.) Thanks!

[Shuhei Takahashi, 2016-09-13 03:46:42]

nya@chromium.org changed reviewers:
+ nya@chromium.org

[Shuhei Takahashi, 2016-09-13 03:46:42]

Quick question: Currently arc-boot-watcher emits arc-booted signal, so this
change will make the signal emitted twice until arc-boot-watcher is disabled. Is
it safe?

[hashimoto, 2016-09-13 03:50:13]

hashimoto@chromium.org changed reviewers:
+ hashimoto@chromium.org

[hashimoto, 2016-09-13 03:50:14]

chromeos/dbus lgtm

[Yusuke Sato, 2016-09-13 03:56:24]

On 2016/09/13 03:46:42, Shuhei Takahashi wrote:
> Quick question: Currently arc-boot-watcher emits arc-booted signal, so this
> change will make the signal emitted twice until arc-boot-watcher is disabled.
Is
> it safe?

Yes, the second signal emit will just be no-op.

[Luis Héctor Chávez, 2016-09-13 16:14:38]

On 2016/09/13 03:56:24, Yusuke Sato wrote:
> On 2016/09/13 03:46:42, Shuhei Takahashi wrote:
> > Quick question: Currently arc-boot-watcher emits arc-booted signal, so this
> > change will make the signal emitted twice until arc-boot-watcher is
disabled.
> Is
> > it safe?
> 
> Yes, the second signal emit will just be no-op.

components/arc lgtm

as for the safety of repeated arc-booted signal emission: currently that signal
only controls the stopping of arc-ureadahead-trace, so the very worst that can
happen is that it will signal it to stop once it's already stopped or stopping;
both cases are no-op.

[Daniel Erat, 2016-09-13 16:18:12]

lgtm

[Shuhei Takahashi, 2016-09-14 03:57:47]

On 2016/09/13 03:56:24, Yusuke Sato wrote:
> On 2016/09/13 03:46:42, Shuhei Takahashi wrote:
> > Quick question: Currently arc-boot-watcher emits arc-booted signal, so this
> > change will make the signal emitted twice until arc-boot-watcher is
disabled.
> Is
> > it safe?
> 
> Yes, the second signal emit will just be no-op.

Thanks for clarification!

[Shuhei Takahashi, 2016-09-14 03:58:03]

Description was changed from

==========
Call session_manager's EmitArcBooted() D-Bus method when ARC is ready

This depends on https://chromium-review.googlesource.com/#/c/384594/

BUG=b:31254747
TEST=manually confirmed that the method is actually called
==========

to

==========
Call session_manager's EmitArcBooted() D-Bus method when ARC is ready

This depends on https://chromium-review.googlesource.com/#/c/384594/

BUG=b:31254747
TEST=manually confirmed that the method is actually called
==========

[Shuhei Takahashi, 2016-09-14 03:58:04]

nya@chromium.org changed reviewers:
- nya@chromium.org

[Yusuke Sato, 2016-09-14 22:48:07]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 22:48:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 00:02:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 00:02:26]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-09-15 00:09:45]

The CQ bit was checked by yusukes@chromium.org

[Yusuke Sato, 2016-09-15 00:09:45]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org,
lhchavez@chromium.org, hashimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2332153002/#ps20001
(title: "rebased on top of my cros_system_api CL to run try, no code change")

[commit-bot: I haz the power, 2016-09-15 00:10:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 00:16:40]

Description was changed from

==========
Call session_manager's EmitArcBooted() D-Bus method when ARC is ready

This depends on https://chromium-review.googlesource.com/#/c/384594/

BUG=b:31254747
TEST=manually confirmed that the method is actually called
==========

to

==========
Call session_manager's EmitArcBooted() D-Bus method when ARC is ready

This depends on https://chromium-review.googlesource.com/#/c/384594/

BUG=b:31254747
TEST=manually confirmed that the method is actually called
==========

[commit-bot: I haz the power, 2016-09-15 00:16:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-15 00:20:11]

Description was changed from

==========
Call session_manager's EmitArcBooted() D-Bus method when ARC is ready

This depends on https://chromium-review.googlesource.com/#/c/384594/

BUG=b:31254747
TEST=manually confirmed that the method is actually called
==========

to

==========
Call session_manager's EmitArcBooted() D-Bus method when ARC is ready

This depends on https://chromium-review.googlesource.com/#/c/384594/

BUG=b:31254747
TEST=manually confirmed that the method is actually called

Committed: https://crrev.com/2171e4b359a0037b7f21f81d381d7d301e79aa9e
Cr-Commit-Position: refs/heads/master@{#418721}
==========

[commit-bot: I haz the power, 2016-09-15 00:20:13]

Patchset 2 (id:??) landed as
https://crrev.com/2171e4b359a0037b7f21f81d381d7d301e79aa9e
Cr-Commit-Position: refs/heads/master@{#418721}