Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 2332123002: Remove reference to common.gypi to un-break closure builders. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
brettw, Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove reference to common.gypi to un-break closure builders. NOTRY=true TBR=brettw@chromium.org, dbeam@chromium.org BUG= Committed: https://crrev.com/d4d31ca6f1257e2f79adf3606037a68d4bd5ca74 Cr-Commit-Position: refs/heads/master@{#418052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/gyp_chromium.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
4 years, 3 months ago (2016-09-12 21:22:51 UTC) #1
Dan Beam
lgtm if this helps
4 years, 3 months ago (2016-09-12 21:23:43 UTC) #2
Dirk Pranke
Looks like this is all that was needed.
4 years, 3 months ago (2016-09-12 21:28:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332123002/1
4 years, 3 months ago (2016-09-12 21:28:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 21:39:04 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 21:40:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4d31ca6f1257e2f79adf3606037a68d4bd5ca74
Cr-Commit-Position: refs/heads/master@{#418052}

Powered by Google App Engine
This is Rietveld 408576698